WordPress.org
Get WordPress

Make WordPress Core

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#24852 closed defect (bug) (fixed)

Revisions Easter Egg should be removed from core

Reported by: noahsilverstein Owned by: markjaquith
Priority: normal Milestone: 3.6
Component: Revisions Version: 3.5.2
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

The easter egg that in the old version of revisions is no longer accessible in the new revisions version. Therefore, it should be removed from core.

Attachments (2)

24852.diff​ (3.3 KB ) - added by noahsilverstein 13 years ago.
Removes revisions easter egg
24852.2.diff​ (3.7 KB ) - added by adamsilverstein 13 years ago.
add removed file to $_old_files

Download all attachments as: .zip

Change History (9)

@noahsilverstein
13 years ago

Removes revisions easter egg

#1 @helen
13 years ago

  • Keywords has-patch added
  • Milestone Awaiting Review → 3.6

#2 @ocean90
13 years ago

$_old_files needs to be updated too.

#3 @hakre
13 years ago

This could also (re-) fix #15262 - But this should probably be kept in to retain backwards compatibility to plugins that make use of that former core-file, compare with the json problem. Normally this should be deprecated first IIRC.

Last edited 13 years ago by hakre (previous) (diff)

#4 @helen
13 years ago

Yeah, we'd need to do a sweep through and clean up any tickets related to this Easter egg. :)

@adamsilverstein
13 years ago

add removed file to $_old_files

#5 @markjaquith
13 years ago

  • Owner set to markjaquith
  • Resolution → fixed
  • Status new → closed

In 24820:

Remove our revisions easter egg, as it doesn't have a place in our new UI.

There will be opportunities for other easter eggs. This one has had its decade.

Fixes #24852 for trunk. Props noahsilverstein.

#6 @markjaquith
13 years ago

In 24821:

Remove our revisions easter egg, as it doesn't have a place in our new UI.

There will be opportunities for other easter eggs. This one has had its decade.

Fixes #24852 for 3.6. Props noahsilverstein.

#7 @mdawaffe
13 years ago

Inconsolabunny.

Note: See TracTickets for help on using tickets.