WordPress.org

Make WordPress Core

Opened 9 months ago

Closed 9 months ago

Last modified 9 months ago

#24852 closed defect (bug) (fixed)

Revisions Easter Egg should be removed from core

Reported by: noahsilverstein Owned by: markjaquith
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.5.2
Component: Revisions Keywords: has-patch
Focuses: Cc:

Description

The easter egg that in the old version of revisions is no longer accessible in the new revisions version. Therefore, it should be removed from core.

Attachments (2)

24852.diff (3.3 KB) - added by noahsilverstein 9 months ago.
Removes revisions easter egg
24852.2.diff (3.7 KB) - added by adamsilverstein 9 months ago.
add removed file to $_old_files

Download all attachments as: .zip

Change History (9)

noahsilverstein9 months ago

Removes revisions easter egg

comment:1 helen9 months ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.6

comment:2 ocean909 months ago

$_old_files needs to be updated too.

comment:3 hakre9 months ago

This could also (re-) fix #15262 - But this should probably be kept in to retain backwards compatibility to plugins that make use of that former core-file, compare with the json problem. Normally this should be deprecated first IIRC.

Last edited 9 months ago by hakre (previous) (diff)

comment:4 helen9 months ago

Yeah, we'd need to do a sweep through and clean up any tickets related to this Easter egg. :)

adamsilverstein9 months ago

add removed file to $_old_files

comment:5 markjaquith9 months ago

  • Owner set to markjaquith
  • Resolution set to fixed
  • Status changed from new to closed

In 24820:

Remove our revisions easter egg, as it doesn't have a place in our new UI.

There will be opportunities for other easter eggs. This one has had its decade.

Fixes #24852 for trunk. Props noahsilverstein.

comment:6 markjaquith9 months ago

In 24821:

Remove our revisions easter egg, as it doesn't have a place in our new UI.

There will be opportunities for other easter eggs. This one has had its decade.

Fixes #24852 for 3.6. Props noahsilverstein.

comment:7 mdawaffe9 months ago

Inconsolabunny.

Note: See TracTickets for help on using tickets.