WordPress.org
Get WordPress

Make WordPress Core

Opened 13 years ago

Closed 8 years ago

Last modified 8 years ago

#24862 closed enhancement (worksforme)

"Add Media" button in editor opens "Insert Media" panel

Reported by: SeReedMedia Owned by:
Priority: normal Milestone:
Component: Text Changes Version: 3.5
Severity: normal Keywords: has-patch ux-feedback
Cc: Focuses: administration

Description

Inconsistent labeling: The "Add Media" button opens the popup panel which is titled "Insert Media".

Please note: Ian told me to add this as a trac ticket :)

Attachments (1)

24862.diff​ (2.2 KB ) - added by devinreams 13 years ago.
Quick pass at renaming button for consistency in dialog name opened

Download all attachments as: .zip

Change History (9)

@devinreams
13 years ago

Quick pass at renaming button for consistency in dialog name opened

#1 @devinreams
13 years ago

  • Keywords has-patch added

I'm not sure if there are localization considerations or perhaps even plugin / theme expectations around the name of this button.

#2 @DrewAPicture
13 years ago

  • Component Media → Text Changes
  • Keywords 2nd-opinion ux-feedback added
  • Severity trivial → normal
  • Version 3.5.2 → 3.5

I think I'd rather change the label on the modal than the text on the button, especially after all of the discussion around returning to 'Add Media' in 3.5.

#3 @chriscct7
11 years ago

  • Focuses administration added
  • Keywords dev-feedback added; 2nd-opinion removed
  • Type defect (bug) → enhancement

This ticket was mentioned in ​Slack in #design by karmatosed. ​View the logs.
9 years ago

#5 @melchoyce
9 years ago

I think I'd rather change the label on the modal than the text on the button, especially after all of the discussion around returning to 'Add Media' in 3.5.

+1

#6 @melchoyce
9 years ago

Pinging @joen for thoughts on how this should work in relation to Gutenberg.

#7 @ghovens
8 years ago

  • Resolution → worksforme
  • Status new → closed

Hi guys,

First day of contributing here so bear with me.

In my version both the button text and the name of the modal show 'Add Media', meaning the incosistency is gone. I think that means this ticket is done?

Kind regards,

Gijs

#8 @ocean90
8 years ago

  • Keywords dev-feedback removed
  • Milestone Awaiting Review
Note: See TracTickets for help on using tickets.