WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 3 months ago

Last modified 2 months ago

#24862 closed enhancement (worksforme)

"Add Media" button in editor opens "Insert Media" panel

Reported by: SeReedMedia Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.5
Component: Text Changes Keywords: has-patch ux-feedback
Focuses: administration Cc:

Description

Inconsistent labeling: The "Add Media" button opens the popup panel which is titled "Insert Media".

Please note: Ian told me to add this as a trac ticket :)

Attachments (1)

24862.diff (2.2 KB) - added by devinreams 5 years ago.
Quick pass at renaming button for consistency in dialog name opened

Download all attachments as: .zip

Change History (9)

@devinreams
5 years ago

Quick pass at renaming button for consistency in dialog name opened

#1 @devinreams
5 years ago

  • Keywords has-patch added

I'm not sure if there are localization considerations or perhaps even plugin / theme expectations around the name of this button.

#2 @DrewAPicture
5 years ago

  • Component changed from Media to Text Changes
  • Keywords 2nd-opinion ux-feedback added
  • Severity changed from trivial to normal
  • Version changed from 3.5.2 to 3.5

I think I'd rather change the label on the modal than the text on the button, especially after all of the discussion around returning to 'Add Media' in 3.5.

#3 @chriscct7
3 years ago

  • Focuses administration added
  • Keywords dev-feedback added; 2nd-opinion removed
  • Type changed from defect (bug) to enhancement

This ticket was mentioned in Slack in #design by karmatosed. View the logs.


11 months ago

#5 @melchoyce
11 months ago

I think I'd rather change the label on the modal than the text on the button, especially after all of the discussion around returning to 'Add Media' in 3.5.

+1

#6 @melchoyce
11 months ago

Pinging @joen for thoughts on how this should work in relation to Gutenberg.

#7 @ghovens
3 months ago

  • Resolution set to worksforme
  • Status changed from new to closed

Hi guys,

First day of contributing here so bear with me.

In my version both the button text and the name of the modal show 'Add Media', meaning the incosistency is gone. I think that means this ticket is done?

Kind regards,

Gijs

#8 @ocean90
2 months ago

  • Keywords dev-feedback removed
  • Milestone Awaiting Review deleted
Note: See TracTickets for help on using tickets.