WordPress.org

Make WordPress Core

Opened 21 months ago

Closed 19 months ago

Last modified 17 months ago

#24863 closed defect (bug) (fixed)

Twenty Fourteen: add a Contributors page template to highlight authors

Reported by: lancewillett Owned by:
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Bundled Theme Keywords: has-patch needs-testing
Focuses: Cc:

Description

For example: http://www.aeonmagazine.com/contributors/

  • Page template should list all authors with at least 1 published post.
  • Link to authors archive.

Attachments (13)

Screenshot from 2013-08-07 10:14:27.png (103.6 KB) - added by Kuzmanov 21 months ago.
style.diff (695 bytes) - added by Kuzmanov 21 months ago.
authors-page.php (1.4 KB) - added by Kuzmanov 21 months ago.
Contributors page template
authors.diff (2.4 KB) - added by MikeHansenMe 21 months ago.
author function and style from previous patch
authors-page.2.php (600 bytes) - added by MikeHansenMe 21 months ago.
page template to call author function and keep content and comments
24863.diff (2.4 KB) - added by MikeHansenMe 20 months ago.
based on new design.
24863.2.diff (2.7 KB) - added by MikeHansenMe 20 months ago.
minor update to previous patch
authors-page.3.php (1.6 KB) - added by MikeHansenMe 20 months ago.
contributor page file with all code within the file
24863.3.diff (1.0 KB) - added by MikeHansenMe 20 months ago.
styles for the newest author page file
24863.4.diff (6.2 KB) - added by obenland 19 months ago.
24863.5.diff (5.2 KB) - added by iamtakashi 19 months ago.
Minor style adjustments to 24863.4.diff
24863.6.diff (6.7 KB) - added by iamtakashi 19 months ago.
Include the missing contributors page template
24863.7.diff (6.5 KB) - added by obenland 19 months ago.

Download all attachments as: .zip

Change History (47)

comment:1 @Frank Klein21 months ago

  • Cc contact@… added

comment:2 @melchoyce21 months ago

  • Cc melissachoyce@… added

comment:3 @DrewAPicture21 months ago

  • Cc xoodrew@… added

comment:4 @iamtakashi21 months ago

  • Cc takashi@… added

@Kuzmanov21 months ago

@Kuzmanov21 months ago

Contributors page template

comment:5 @MikeHansenMe21 months ago

  • Cc mdhansen@… added

A few ideas I have for this page are to also show the users gravatar if they have one and to still allow the page content to be displayed either below or above the authors. I have a template I have been playing with but it still needs a little work before I post it. Hopefully today sometime.

@MikeHansenMe21 months ago

author function and style from previous patch

@MikeHansenMe21 months ago

page template to call author function and keep content and comments

comment:6 @jazzs3quence20 months ago

  • Cc jazzs3quence added

comment:7 @MikeHansenMe20 months ago

  • Keywords has-patch needs-testing added; needs-patch removed

comment:8 @obenland20 months ago

I'd like to wait with that until iamtakashi had a chance to come up with a design for the page.

comment:9 @MikeHansenMe20 months ago

The patch could easily be updated to meet a new design. Let's wait to get some input from iamtakashi.

comment:10 @iamtakashi20 months ago

I'll work on a mockup for the contributors page.

comment:11 @SergeyBiryukov20 months ago

  • Version set to trunk

comment:12 @iamtakashi20 months ago

I've worked on a mockup for the contributors page.

http://f.cl.ly/items/1C261Z3C3b3q2O3G2033/2014-contributors.jpg

I think it's the best to order contibutors on the page by their number of published articles. Plus, to make the ordering clear, it would be good to print the number of articles on the button that takes to the author archive page. I used the document icon from Genericons in the mockup but it could say "Read xx Articles" or "View xx Articles" or whatever we think most appropriate. What do you guys think?

comment:13 follow-up: @obenland20 months ago

I like it! What made you go with a one-column layout instead of a two- or three-column layout for example?

comment:14 in reply to: ↑ 13 @iamtakashi20 months ago

Replying to obenland:

I like it! What made you go with a one-column layout instead of a two- or three-column layout for example?

Although we can use the Masonry, I found the layout can be messy with various text lengthes of biographies in two- or three-column layout and the readability will definitely suffer, and also the ordering will be obscured with multi-column Masonry powered layout.

Another reason was that, for that page, I wanted to use a good size of avatars, not like the ones in comments because these are more important on the page.

In my opinion, this one-column layout is cleaner and safer especially when a site has only a few contributors. Even a site has few dozens of contributors, the page wouldn't look horrible because it's clean and airy.

I'm glad you like it!

comment:15 @jazzs3quence20 months ago

I like it a lot, too, and I agree with the design decisions you made re: one column layout.

comment:16 @lancewillett20 months ago

Looks great, Takashi. Let's code it up. :)

@MikeHansenMe20 months ago

based on new design.

comment:17 @MikeHansenMe20 months ago

24863.diff uses author-page.2.php. It still allows for content if there is any. It will likely need more tuning, it is missing the icon in the button also.

@MikeHansenMe20 months ago

minor update to previous patch

comment:18 @karmatosed20 months ago

  • Cc karmatosed@… added

comment:19 @lancewillett20 months ago

Discussed today in office hours, next step is testing and patch code review.

comment:20 @iamtakashi20 months ago

I'll do tuning CSS once we are happy with the implementation.

comment:21 @obenland20 months ago

Mike, could you see where using get_users() gets you? You can set it to order by post count and it should give you all the user information we need.

I'm not sure we actually need the .contributor-info div, we should be fine without it. .contributor-button should be outside the bio, see it more like meta info to the bio content. We might also be able to do all that in a page template.

comment:22 @MikeHansenMe20 months ago

yep, I will see what I can do. Then submit a new patch.

@MikeHansenMe20 months ago

contributor page file with all code within the file

@MikeHansenMe20 months ago

styles for the newest author page file

@obenland19 months ago

comment:23 follow-up: @obenland19 months ago

24863.4.diff is based on MikeHansenMe's work and iamtakashi's mockup.

Takashi, could you make sure I got the colors, font-sizes, and widths/margins right?

comment:24 @jcastaneda19 months ago

  • Cc jomcastaneda@… added

@iamtakashi19 months ago

Minor style adjustments to 24863.4.diff

comment:25 in reply to: ↑ 23 ; follow-up: @iamtakashi19 months ago

Replying to obenland:

Takashi, could you make sure I got the colors, font-sizes, and widths/margins right?

Adjusted slightly some styles. We can improve its responsive pattern when the patch in #25332 is committed.

comment:26 in reply to: ↑ 25 ; follow-up: @obenland19 months ago

Replying to iamtakashi:

Adjusted slightly some styles. We can improve its responsive pattern when the patch in #25332 is committed.

Your patch is missing the page template :(

@iamtakashi19 months ago

Include the missing contributors page template

comment:27 in reply to: ↑ 26 @iamtakashi19 months ago

Replying to obenland:

Your patch is missing the page template :(

Oops. Sorry about that! Added a patch with the page template.

comment:28 follow-up: @lancewillett19 months ago

Patch is looking great. One thing I noticed, and can be fixed in a later patch, is the word "Articles" isn't set up for translating numbers like 0, 1, n in various languages.

<?php printf( __( '%d Articles', 'twentyfourteen' ), $post_count ); ?>

and when an author has only 1 post, it still says "0 Articles" plural.

comment:29 in reply to: ↑ 28 @obenland19 months ago

Replying to lancewillett:

Patch is looking great. One thing I noticed, and can be fixed in a later patch, is the word "Articles" isn't set up for translating numbers like 0, 1, n in various languages.

Good catch, let me update real quick.

comment:30 @lancewillett19 months ago

Noting also the Genericons class should probably be removed and use CSS instead, as per changes in #25085. For adding the "document" icon.

comment:31 @obenland19 months ago

Should I wait with a refresh until #25085 is in?

@obenland19 months ago

comment:32 @lancewillett19 months ago

In 25510:

Twenty Fourteen: first pass at adding a Contributors page template to highlight authors. Props MikeHansenMe, iamtakashi, obenland, and Kuzmanov. See #24863.

comment:33 @lancewillett19 months ago

  • Resolution set to fixed
  • Status changed from new to closed

Let's open new issues in new tickets.

comment:34 @lancewillett17 months ago

In 26657:

Twenty Fourteen: change sort order on Contributor template to put author with mosts posts at the top. Props iamtakashi, closes #26427; see #24863.

Note: See TracTickets for help on using tickets.