WordPress.org

Make WordPress Core

Opened 2 years ago

Last modified 19 months ago

#24867 assigned defect (bug)

Feeds for custom posts type can not be set independently of has_archive and supports => comments

Reported by: marcosf Owned by: nacin
Milestone: Future Release Priority: normal
Severity: normal Version: 3.8
Component: Posts, Post Types Keywords: has-patch
Focuses: Cc:

Description (last modified by ocean90)

I was testing the patch for ticket (Feeds or Feed - add_permastruct missunderstanding: #23302) and discovered a few things (I'm using trunk rev 19712).

Turning of feeds for custom post types only works if supports feeds & has_archive are set to either false or true.

If you, e.g. set the argument feeds in rewrite to true and has_archive to false then the rewrite rules for feeds do not get created (some happens of you switch true & false around in both arguments).

This happens due to this condition in /wp-includes/post.php, line 1242:

 if ( ! isset( $args->rewrite['feeds'] ) OR ! $args->has_archive )
  $args->rewrite['feeds'] = (bool) $args->has_archive;

Another problem I run into is that:
With the patch for ticket (#23302) you can not enable/disable the comments feed independent of the main feed of the custom post type. It also does not get disabled if you do not enabled comments via supports. Rewrite rules for feeds seem to always get created.

I've attached an example to showcase what I wrote above.

Attachments (2)

feeds.php (1.2 KB) - added by marcosf 2 years ago.
Test to turn of feeds
24867.diff (1.1 KB) - added by marcosf 2 years ago.

Download all attachments as: .zip

Change History (8)

@marcosf2 years ago

Test to turn of feeds

@marcosf2 years ago

comment:1 @marcosf2 years ago

  • Cc marcosf added

comment:2 @marcosf2 years ago

  • Keywords has-patch added

comment:3 @nacin2 years ago

  • Milestone changed from Awaiting Review to 3.7
  • Owner set to nacin
  • Status changed from new to assigned

I talked through this patch with marcosf at the WCSF contributor day. Needs testing, but looks proper. Probably also needs a DB version bump to flush rewrite rules.

comment:4 @ocean902 years ago

  • Description modified (diff)

comment:5 @nacin21 months ago

  • Milestone changed from 3.7 to 3.8

This is unfortunately a bit more complicated, see #16415.

comment:6 @nacin19 months ago

  • Milestone changed from 3.8 to Future Release
Note: See TracTickets for help on using tickets.