Gallery shortcode removes orderby

[markoheijnen]

WordPress doesn't support it anymore but when old shortcode still have the orderby value in the shortcode it gets removed when updating the gallery. It's still used in the shortcode and people still can add it manually when using the text editor

[nofearinc]

This is not exactly a great fix, but I wasn't able to find a better solution.

The problem was that all orderby actions are oriented around the Random Order checkbox in the gallery manager. Whenever "Random Order" is checked, the orderby attribute is placed with a value of "rand" and if the checkbox is empty, then no orderby attribute is set.

The patch is adding another field that keeps the old value for persistence. If the "Random Order" value is not checked, the old orderby value is stored. If it is checked, then the value is updated - and finally if it was checked, but then unchecked, the orderby is cleared.

[nacin]

This is not exactly a great fix, but I wasn't able to find a better solution.

Agree with the sentiment. Looks good at a glance.

[markoheijnen]

I just checked the code and to me it's good to go in.

[johnbillion]

Just chatted with Marko on this. Tested and confirmed as working.

[nacin]

In 25720:

Prevent the removal of a manual 'orderby' attribute in the gallery shortcode.

props nofearinc.
fixes #24868.