"All" in post list table is incorrectly selected in some filtered views

[enej]

When you are viewing the posts table and you have selected an author the all filter is incorrectly selected.

[enej]

screenshot

[enej]

patch that removed the selection of all.

[enej]

This patch should fix it.

[rmarks]

This patch includes 24869.diff​ by enej plus adds the cases when a category or tag is specified

[rmarks]

Replying to enej:

This patch should fix it.

I added to your patch by including the exceptions when a category or tag was specified.

[helen]

Is there something we can do besides continuing to add to the conditional? For example, as what is probably a TERRIBLE idea, comparing the post count of all vs. the current view.

[sworddance]

@helen - "Is there something we can do besides continuing to add to the conditional?"

An alternative would be to see if the only $_REQUEST parameter is post_type. so something like:

count($_REQUEST) == 0 || count($_REQUEST) == 1 && isset($_REQUEST['post_type'])

[rmarks]

I have just uploaded an alternate diff that accomplishes @enej's intentions while using @sworddance's suggestions.

[pauldewouters]

I tested the patch and can confirm it fixes the issue

[wonderboymusic]

I have been in list tables pretty deep recently, I would like to fix this

[wonderboymusic]

24869.3.diff​ fixes this, sorry it sat for so long, enej!

[DrewAPicture]

Latest patch still applies, appears to fix the problem. The new method, is_base_request(), should have a DocBlock. Otherwise looks ready for commit consideration.

[wonderboymusic]

In 31828:

Add WP_Posts_List_Table::is_base_request() to determine if the current "view" is the "All" (default) view.

Fixes #24869.

[nacin]

Replying to wonderboymusic:

In 31828:

Add WP_Posts_List_Table::is_base_request() to determine if the current "view" is the "All" (default) view.

Fixes #24869.

@wonderboymusic, I don't think this is a problem in terms of how this is implemented (perhaps just how it is documented), but note that for Contributors and Authors (I think), the first section is actually "Mine", not "All".

[DrewAPicture]

See comment:17. Also, not sure this is working correctly even for roles that lack the "Mine" section. When the "All" section is selected, none of them have the current class. I think we need another look here.

[wonderboymusic]

In 31959:

In WP_Posts_List_Table::get_views(), don't add the current class to the all status link if ->user_posts_count has a value, which triggers the additional mine status.

See [31828].
Fixes #24869.