Revisions: bugs when reloading on initial revision

[adamsilverstein]

Changeset [24667] introduced a bug where the revisions screen loads incorrectly if the selected revision is the original (1st) revision. to reproduce: go to the revisions screen; move the slider handle to the 1st (left in LTR) position; reload the page - expected behaviour is to see the diff, instead a no change diff is displayed.

Changeset [24814] introduced a bug where the tooltip placement is off, initially, for the leftmost tooltip position; to reproduce, go to the revisions screen; move the slider handle to the 1st (left in LTR) position; reload the page; hover over the leftmost revision WITHOUT first hovering over any other tick marks, the tooltip will be way off position to the left

[adamsilverstein]

corrects bugs when loading revisions screen on initial revision with diff display and tooltip placement

[adamsilverstein]

upon further testing, i have noticed that reloading the revisions screen on the non initial revisions breaks with this patch applied, investigating; the tooltip placement is corrected by the patch, resubmitting with only that change.

[adamsilverstein]

FIX tooltip placement on initial load

[aaroncampbell]

I wasn't able to reproduce the first issue by getting a blank diff, but I was able to see an issue when loading with the first revisions selected. Basically, when you load with the first revision selected it is comparing FROM the last revision TO the first. 28873.3.diff​ checks to see if we're looking at the first revision and sets the FROM to 0.

[aaroncampbell]

I can reproduce the first bug exactly, as long as the first revision and last revision match. In that case, when it compares the two, you see a no change diff.

[adamsilverstein]

proper diff loading on initial revision reload

[adamsilverstein]

ooops, posted patch before refreshing so missed your patches. tested 24873.diff​ and that correctly fixes both issues mentioned in this ticket.

[markjaquith]

In 24864:

Revisions: Fix PHP loading of comparison to first revision, and premature rendering of tooltip.

Props aaroncampbell, markjaquith. Fixes #24873 for trunk.

[markjaquith]

In 24865:

Revisions: Fix PHP loading of comparison to first revision, and premature rendering of tooltip.

Props aaroncampbell, markjaquith. Fixes #24873 for 3.6.

[nacin]

In 24866:

Fix pass by reference issue. see #24873.

[nacin]

In 24867:

Fix pass by reference issue. see #24873.

Merges [24865] to the 3.6 branch.