WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#24874 closed defect (bug) (fixed)

Twenty Fourteen: Change to just one footer widget area and use Masonry

Reported by: Frank Klein Owned by: lancewillett
Milestone: 3.8 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:
PR Number:

Description

As noted in #24858, the footer sidebar of the Further theme should be converted to use only one widget area, with jQuery Masonry handling the vertical alignment of the widget.

A patch with a first pass at this will follow soon.

Attachments (2)

24874.patch (7.4 KB) - added by Frank Klein 6 years ago.
24874.2.patch (8.3 KB) - added by Frank Klein 6 years ago.

Download all attachments as: .zip

Change History (9)

@Frank Klein
6 years ago

#1 @Frank Klein
6 years ago

  • Cc contact@… added
  • Keywords has-patch added

#2 @lancewillett
6 years ago

  • Milestone changed from Awaiting Review to 3.8

#3 @obenland
6 years ago

Nice patch Frank! Some minor nit picks that would make it beyond great:

  • We try to not use IDs as selectors, to make it easy to override them.
  • Let's call it a 'Footer Widget Area' as it is not really a sidebar.
  • Single line if/else blocks can omit braces for brevity (#)
  • I think we can optimize the masonry selector to be just #footer-sidebar.

#4 @Frank Klein
6 years ago

Thanks Konstantin for looking at the patch.

I updated it to fix the points that you outlined.

@Frank Klein
6 years ago

#5 @lancewillett
6 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 25065:

Twenty Fourteen: change to just one footer widget area and use Masonry JS to display the widgets in columns. Props Frank Klein, closes #24874.

#6 @nacin
6 years ago

In 25190:

Be less verbose when erroring out in do_feed() for an invalid feed template. fixes #24874.

Note: See TracTickets for help on using tickets.