Make WordPress Core

Context Navigation

← Previous Ticket
Next Ticket →

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#24874 closed defect (bug) (fixed)

Twenty Fourteen: Change to just one footer widget area and use Masonry

Reported by:	anonymized_8769252	Owned by:	lancewillett
Priority:	normal	Milestone:	3.8
Component:	Bundled Theme	Version:
Severity:	normal	Keywords:	has-patch
Cc:		Focuses:

Description

As noted in #24858, the footer sidebar of the Further theme should be converted to use only one widget area, with jQuery Masonry handling the vertical alignment of the widget.

A patch with a first pass at this will follow soon.

Attachments (2)

24874.patch (7.4 KB ) - added by anonymized_8769252 13 years ago.
24874.2.patch (8.3 KB ) - added by anonymized_8769252 13 years ago.

Download all attachments as: .zip

Change History (9)

@anonymized_8769252
13 years ago

Attachment 24874.patch added

#1 @anonymized_8769252
13 years ago

Cc contact@… added
Keywords has-patch added

#2 @lancewillett
13 years ago

Milestone Awaiting Review → 3.8

#3 @obenland
13 years ago

Nice patch Frank! Some minor nit picks that would make it beyond great:

We try to not use IDs as selectors, to make it easy to override them.
Let's call it a 'Footer Widget Area' as it is not really a sidebar.
Single line if/else blocks can omit braces for brevity (#)
I think we can optimize the masonry selector to be just #footer-sidebar.

#4 @anonymized_8769252
13 years ago

Thanks Konstantin for looking at the patch.

I updated it to fix the points that you outlined.

@anonymized_8769252
13 years ago

Attachment 24874.2.patch added

#5 @lancewillett
13 years ago

Owner set to lancewillett
Resolution → fixed
Status new → closed

Twenty Fourteen: change to just one footer widget area and use Masonry JS to display the widgets in columns. Props Frank Klein, closes #24874.

#6 @nacin
13 years ago

Be less verbose when erroring out in do_feed() for an invalid feed template. fixes #24874.

#7 @SergeyBiryukov
13 years ago

[25190] was for #24784.

Note: See TracTickets for help on using tickets.

Download in other formats: