WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 22 months ago

Last modified 21 months ago

#24877 closed defect (bug) (fixed)

Twenty Fourteen: Align post format handling with Twenty Thirteen

Reported by: Frank Klein Owned by: lancewillett
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Bundled Theme Keywords:
Focuses: Cc:

Description

As a follow-up to #24858, the handling of the post formats in Twenty Fourteen should be aligned with how Twenty Thirteen or _s does this.

Attachments (2)

24877.patch (29.2 KB) - added by Frank Klein 2 years ago.
24877.1.diff (27.3 KB) - added by obenland 23 months ago.

Download all attachments as: .zip

Change History (15)

@Frank Klein2 years ago

comment:1 @Frank Klein2 years ago

  • Cc contact@… added
  • Keywords has-patch added

The changes:

  • Deleted content-post-format.php and content-single.php.
  • Added template parts for each of the supported post formats.
  • Updated index.php, search.php, archive.php and single.php to match the new structure of the template parts.
  • Moved the archive/single view display logic into the templates.
  • Moved the display of the post format, the categories and the tags into custom template tags to avoid code duplication.
  • Removed the title output for certain post formats instead of hiding it via CSS.

Gallery Post Format:

In the old content-post-format.php there was specific code to handle the thumbnail images differently for archive and single views.

However the twentyfourteen_get_template_part() function didn't use this template for the display of the gallery post format.

The new content-gallery.php includes this different handling for archive and single views, which might or might not be the authors intention.

comment:2 @DrewAPicture2 years ago

  • Cc xoodrew@… added

comment:3 @lancewillett2 years ago

  • Milestone changed from Awaiting Review to 3.8

@obenland23 months ago

comment:4 @obenland23 months ago

Updated patch based on Frank Klein's work.

comment:5 @lancewillett23 months ago

In 25088:

Twenty Fourteen: Align post format handling with Twenty Thirteen. Props Frank Klein and obenland, see #24877.

comment:6 @lancewillett23 months ago

  • Keywords needs-testing added; has-patch removed

Leaving this ticket open for more testing.

comment:7 @SergeyBiryukov22 months ago

  • Version set to trunk

comment:8 @MikeHansenMe22 months ago

  • Keywords needs-refresh added

The patch failed when applied for testing.

comment:9 @obenland22 months ago

  • Keywords needs-refresh removed

It is already committed, it only needs some additional confirmational testing.

comment:10 @MikeHansenMe22 months ago

Guess I missed comment 5... I will what is currently committed.

comment:11 @obenland22 months ago

  • Owner set to lancewillett
  • Status changed from new to assigned

comment:12 @obenland22 months ago

  • Keywords needs-testing removed
  • Resolution set to fixed
  • Status changed from assigned to closed

This is good to go. If you find a bug related to this, feel free to open a new ticket.

comment:13 @lancewillett21 months ago

In 25768:

Twenty Fourteen: remove two unused files, should have been deleted with r25088, see #24877.

Note: See TracTickets for help on using tickets.