Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#24877 closed defect (bug) (fixed)

Twenty Fourteen: Align post format handling with Twenty Thirteen

Reported by: Frank Klein Owned by: lancewillett
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Bundled Theme Keywords:
Focuses: Cc:


As a follow-up to #24858, the handling of the post formats in Twenty Fourteen should be aligned with how Twenty Thirteen or _s does this.

Attachments (2)

24877.patch (29.2 KB) - added by Frank Klein 2 years ago.
24877.1.diff (27.3 KB) - added by obenland 2 years ago.

Download all attachments as: .zip

Change History (15)

@Frank Klein
2 years ago

#1 @Frank Klein
2 years ago

  • Cc contact@… added
  • Keywords has-patch added

The changes:

  • Deleted content-post-format.php and content-single.php.
  • Added template parts for each of the supported post formats.
  • Updated index.php, search.php, archive.php and single.php to match the new structure of the template parts.
  • Moved the archive/single view display logic into the templates.
  • Moved the display of the post format, the categories and the tags into custom template tags to avoid code duplication.
  • Removed the title output for certain post formats instead of hiding it via CSS.

Gallery Post Format:

In the old content-post-format.php there was specific code to handle the thumbnail images differently for archive and single views.

However the twentyfourteen_get_template_part() function didn't use this template for the display of the gallery post format.

The new content-gallery.php includes this different handling for archive and single views, which might or might not be the authors intention.

#2 @DrewAPicture
2 years ago

  • Cc xoodrew@… added

#3 @lancewillett
2 years ago

  • Milestone changed from Awaiting Review to 3.8

2 years ago

#4 @obenland
2 years ago

Updated patch based on Frank Klein's work.

#5 @lancewillett
2 years ago

In 25088:

Twenty Fourteen: Align post format handling with Twenty Thirteen. Props Frank Klein and obenland, see #24877.

#6 @lancewillett
2 years ago

  • Keywords needs-testing added; has-patch removed

Leaving this ticket open for more testing.

#7 @SergeyBiryukov
2 years ago

  • Version set to trunk

#8 @MikeHansenMe
2 years ago

  • Keywords needs-refresh added

The patch failed when applied for testing.

#9 @obenland
2 years ago

  • Keywords needs-refresh removed

It is already committed, it only needs some additional confirmational testing.

#10 @MikeHansenMe
2 years ago

Guess I missed comment 5... I will what is currently committed.

#11 @obenland
2 years ago

  • Owner set to lancewillett
  • Status changed from new to assigned

#12 @obenland
2 years ago

  • Keywords needs-testing removed
  • Resolution set to fixed
  • Status changed from assigned to closed

This is good to go. If you find a bug related to this, feel free to open a new ticket.

#13 @lancewillett
2 years ago

In 25768:

Twenty Fourteen: remove two unused files, should have been deleted with r25088, see #24877.

Note: See TracTickets for help on using tickets.