WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#24880 closed defect (bug) (fixed)

"Revisions: %s" untranslatable

Reported by: alex-ye Owned by: nacin
Milestone: 3.6 Priority: normal
Severity: normal Version:
Component: Revisions Keywords: has-patch commit
Focuses: Cc:

Description

In some cases the "Revisions: %s" string shown only in English,

when I search in the codes, It seems that you miss the call of __() function.

Attachments (1)

meta-boxes.patch (706 bytes) - added by alex-ye 7 years ago.

Download all attachments as: .zip

Change History (6)

@alex-ye
7 years ago

#1 @markoheijnen
7 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 3.6

#2 follow-up: @ocean90
7 years ago

In line 182 we also have a + sign. Not sure if it needs to be translatable for RTL?

#3 in reply to: ↑ 2 @nacin
7 years ago

Replying to ocean90:

In line 182 we also have a + sign. Not sure if it needs to be translatable for RTL?

I thought about that. Dunno.

#4 @nacin
7 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 24885:

Add missing gettext. This is not a new string; it already exists a few lines up. props alex-ye, fixes #24880.

#5 @nacin
7 years ago

In 24887:

Add missing gettext. This is not a new string; it already exists a few lines up. props alex-ye, fixes #24880.

Merges [24885] to 3.6.

Note: See TracTickets for help on using tickets.