Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#24891 closed defect (bug) (fixed)

Similar strings in Twenty Thirteen

Reported by: pavelevap's profile pavelevap Owned by: lancewillett's profile lancewillett
Milestone: 3.7 Priority: normal
Severity: normal Version: 3.7
Component: Bundled Theme Keywords:
Focuses: Cc:

Description

I am not sure if it was intended, but there are very similar strings in 2013 theme:

  • "Not found" x "Nothing Found"
  • "Post navigation" x "Posts navigation"

Maybe they could be merged?

Attachments (4)

24891.404-not-found.png (12.4 KB) - added by SergeyBiryukov 11 years ago.
24891.404-nothing-found.png (12.6 KB) - added by SergeyBiryukov 11 years ago.
24891.nothing-found.png (4.4 KB) - added by SergeyBiryukov 11 years ago.
24891.404-nothing-found.2.png (14.6 KB) - added by SergeyBiryukov 11 years ago.

Download all attachments as: .zip

Change History (18)

#1 @lancewillett
11 years ago

  • Component changed from I18N to Bundled Theme
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 3.6

I *think* this was already reported ... now looking for the other ticket.

#2 @obenland
11 years ago

Post navigation vs. Posts navigation is a singular/plural difference that makes sense IMO.
I think the other one can be merged.

#3 @lancewillett
11 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 24904:

Twenty Thirteen: combine two similar Nothing Found strings. Fixes #24891.

#4 @pavelevap
11 years ago

It was committed probably only to trunk by mistake and not to 3.6 branch, so we should change milestone?

#5 @SergeyBiryukov
11 years ago

  • Keywords needs-patch removed
  • Milestone changed from 3.6 to 3.7

#6 follow-up: @pavelevap
11 years ago

Thank you, Sergey!

But now I realized why there were different strings. "Not found" was probably shorter version to better fit into 404.php template. Sorry, maybe revert for 3.7?

I also noticed some other similar strings, but they are probably intended even if there is a small difference:

It seems we can’t find what you’re looking for. Perhaps searching can help.

It looks like nothing was found at this location. Maybe try a search?

#7 in reply to: ↑ 6 ; follow-up: @SergeyBiryukov
11 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Replying to pavelevap:

But now I realized why there were different strings. "Not found" was probably shorter version to better fit into 404.php template. Sorry, maybe revert for 3.7?

Indeed, "Not Found" looks better in the 404 template: 24891.404-not-found.png vs. 24891.404-nothing-found.png.

"Nothing Found", on the other hand, is also displayed when nothing is found in a search: 24891.nothing-found.png, and it's probably better than "Not Found" there.

So a revert makes sense to me.

#8 in reply to: ↑ 7 @SergeyBiryukov
11 years ago

Replying to SergeyBiryukov:

Indeed, "Not Found" looks better in the 404 template

Especially in smaller resolutions, where "Nothing Found" is partially hidden: 24891.404-nothing-found.2.png.

#9 @lancewillett
11 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 25515:

Twenty Thirteen: revert combining two similar Nothing Found strings. Closes #24891.

#10 @pavelevap
11 years ago

Sorry for problems, but maybe next time there should be a note for translators to explain original idea. I am not sure if all translators tried to use the shortest translation in this case...

#11 @nacin
11 years ago

In 25906:

Twenty Thirteen: Restore the original "Not found" string. see #24891.

#12 @nacin
11 years ago

In 25907:

Twenty Thirteen: Restore the original "Not found" string. see #24891, for trunk.

#13 @lancewillett
11 years ago

In 26002:

Twenty Thirteen: capitalize "Not Found" string for use in a page title, see #24891 and r25907.

#14 @SergeyBiryukov
11 years ago

  • Version changed from trunk to 3.7
Note: See TracTickets for help on using tickets.