#24891 closed defect (bug) (fixed)
Similar strings in Twenty Thirteen
Reported by: | pavelevap | Owned by: | lancewillett |
---|---|---|---|
Milestone: | 3.7 | Priority: | normal |
Severity: | normal | Version: | 3.7 |
Component: | Bundled Theme | Keywords: | |
Focuses: | Cc: |
Description
I am not sure if it was intended, but there are very similar strings in 2013 theme:
- "Not found" x "Nothing Found"
- "Post navigation" x "Posts navigation"
Maybe they could be merged?
Attachments (4)
Change History (18)
#1
@
11 years ago
- Component changed from I18N to Bundled Theme
- Keywords needs-patch added
- Milestone changed from Awaiting Review to 3.6
#2
@
11 years ago
Post navigation vs. Posts navigation is a singular/plural difference that makes sense IMO.
I think the other one can be merged.
#3
@
11 years ago
- Owner set to lancewillett
- Resolution set to fixed
- Status changed from new to closed
In 24904:
#4
@
11 years ago
It was committed probably only to trunk by mistake and not to 3.6 branch, so we should change milestone?
#6
follow-up:
↓ 7
@
11 years ago
Thank you, Sergey!
But now I realized why there were different strings. "Not found" was probably shorter version to better fit into 404.php template. Sorry, maybe revert for 3.7?
I also noticed some other similar strings, but they are probably intended even if there is a small difference:
It seems we can’t find what you’re looking for. Perhaps searching can help. It looks like nothing was found at this location. Maybe try a search?
#7
in reply to:
↑ 6
;
follow-up:
↓ 8
@
11 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Replying to pavelevap:
But now I realized why there were different strings. "Not found" was probably shorter version to better fit into 404.php template. Sorry, maybe revert for 3.7?
Indeed, "Not Found" looks better in the 404 template: 24891.404-not-found.png vs. 24891.404-nothing-found.png.
"Nothing Found", on the other hand, is also displayed when nothing is found in a search: 24891.nothing-found.png, and it's probably better than "Not Found" there.
So a revert makes sense to me.
#8
in reply to:
↑ 7
@
11 years ago
Replying to SergeyBiryukov:
Indeed, "Not Found" looks better in the 404 template
Especially in smaller resolutions, where "Nothing Found" is partially hidden: 24891.404-nothing-found.2.png.
I *think* this was already reported ... now looking for the other ticket.