WordPress.org

Make WordPress Core

Opened 12 months ago

Closed 12 months ago

Last modified 7 months ago

#24905 closed defect (bug) (fixed)

Twenty Thirteen: Check multiple post formats by passing them as an array

Reported by: obenland Owned by: nacin
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

Since r24817 we can check for more than one post format at once. Let's update Twenty Thirteen with that.

Attachments (1)

24905.diff (874 bytes) - added by obenland 12 months ago.

Download all attachments as: .zip

Change History (8)

obenland12 months ago

comment:1 markjaquith12 months ago

r24817 would have to get applied to branches/3.6.

comment:2 follow-up: lancewillett12 months ago

+1 to the change, but I think it's OK to put this in a later version of the theme.

comment:3 in reply to: ↑ 2 ; follow-up: nacin12 months ago

Replying to lancewillett:

+1 to the change, but I think it's OK to put this in a later version of the theme.

Going into a later version means it loses compatibility with 3.6. So this is either a commit-it-now or a wontfix. I'm fine with either.

I think this would be cleaner if it wasn't a ternary. Don't think the call(s) to has_post_format() makes any difference.

comment:4 in reply to: ↑ 3 obenland12 months ago

Replying to nacin:

Going into a later version means it loses compatibility with 3.6. So this is either a commit-it-now or a wontfix. I'm fine with either.

I'd really like to see it go in if we still have the option. It would also help us with making Twenty Fourteen 3.6 compatible.

comment:5 nacin12 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 24934:

Twenty Thirteen: Call has_post_format() with the new array style. props obenland, fixes #24905.

comment:6 nacin12 months ago

In 24935:

Twenty Thirteen: Call has_post_format() with the new array style. props obenland, fixes #24905. Merges [24934] to 3.6.

comment:7 SergeyBiryukov7 months ago

  • Version changed from trunk to 3.6
Note: See TracTickets for help on using tickets.