WordPress.org

Make WordPress Core

#24909 closed enhancement (wontfix)

Twenty Fourteen: Search Toggle Fade In/Out

Reported by: noam@… Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.8
Component: Bundled Theme Keywords:
Focuses: Cc:

Description

The visibility toggle for the search bar and the social links are using display none;
This patch adds a nicer fade in and fade out using jQuery's fadeToggle().

Attachments (1)

24909.diff (1.4 KB) - added by noam@… 22 months ago.

Download all attachments as: .zip

Change History (8)

@noam@…22 months ago

comment:1 @MikeHansenMe22 months ago

  • Keywords has-patch added

comment:2 @sabreuse22 months ago

Why use jQuery when we could do this with a CSS transition?

comment:3 @lancewillett22 months ago

  • Keywords ui-feedback added

Needs discussion with iamtakashi from a bigger picture of the design and interaction goals. Me personally, I'm fine with CSS hide/show without any kind of transition.

comment:4 @obenland21 months ago

  • Keywords close added

-1. I agree with lancewillett, I think it would make it laggy.

comment:5 @cainm21 months ago

Also fine with leaving it as is. JS seems like extra.

comment:6 @iamtakashi21 months ago

In most of cases, I like quick interaction without any lag when revealing/hiding physically small UI elements. If the interaction was something that impacts page layout significantly fading could be a nice to have effect but, in this case, I'll vote to leave as it is.

comment:7 @obenland21 months ago

  • Keywords has-patch ui-feedback close removed
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed
  • Version set to trunk
Note: See TracTickets for help on using tickets.