#24921 closed defect (bug) (fixed)
Once the admin menu is collapsed, the user setting gets stuck on collapsed
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.6.1 | Priority: | normal |
Severity: | normal | Version: | 3.5 |
Component: | Administration | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
Seems like once you collapse the admin menu and the mfold
user setting is set, it doesn't ever get unset. I'm seeing this in the 3.6 branch and the 3.6 package shipped today.
I tried to trace it back to any recent changes made but I couldn't find anything. Tested in FF, Chrome and Safari on local and on a server.
Works as expected in trunk.
To reproduce:
- In the Dashboard, collapse the admin menu
- Refresh. Expected: Collapsed, Actual: Collapsed.
- Expand the menu.
- Refresh. Expected: Expanded, Actual: Collapsed.
Attachments (6)
Change History (22)
#3
@
12 years ago
Could reproduce it on a clean install. The setting is cleared from the cookie, but get_user_setting('mfold')
in admin-header.php still returns 'f'.
#7
@
12 years ago
24921.2.patch fixes updating the user option when the cookie is empty. May not be suitable for a dot release as it changes the behaviour a bit, but it will fix all user settings not just 'mfold'.
In the meantime a workaround for new installs is to change another user-state setting, for example resize the editor or switch Visual => Text and back.
#8
@
12 years ago
24921.3.patch is same as 24921.2.patch plus:
- Use get_current_user_id() instead of wp_get_current_user() as only the user ID is needed.
- Use is_user_member_of_blog().
- Some cleanup of var names, erc.
#9
@
11 years ago
- Owner set to azaozz
- Resolution set to fixed
- Status changed from new to closed
In 25109:
#11
@
11 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Yeah, was just going to reopen it for 3.6.1. This hasn't been working properly for ages, introduced probably in 2.8-2.9.
It makes difference only on brand new installs. As soon as the user switches Visual => Text or resizes the editor, the cookie is not empty any more and folding/unfolding works as expected. Not sure if a subset from the patch should go in 3.6.1. It's not a regression in 3.6.
#13
@
11 years ago
- Keywords commit added; dev-feedback removed
Let's do 24921.patch for 3.6.1. Per IRC with duck_, "Not a 3.6 regression, but it only affects new installs so would be good to have fixed in the lastest package".
Tried to reproduce this with Firefox 22 and Chrome 28, on both LAMP and WIMP installations running WP 3.6 (auto upgraded from 3.5.2). Could not reproduce.