wp_link_pages() adds separator before pagination links

[Frank Klein]

r23653 introduced a new 'separator' argument that can be passed to wp_link_pages(). According to the inline documentation, the separator is used between pagination links.

So if you call the function like this: wp_link_pages( array( 'separator' => ' > ' ) ); the expected output would be "Pages: 1 > 2 > 3", however the actual output is "Pages: > 1 > 2 > 3".

As I understand the documentation, the separator text should only be printed between the links and not before.

[SergeyBiryukov]

The IRC discussion: ​https://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2013-03-08&sort=asc#m571427

[Frank Klein]

Thanks for posting the link to the IRC discussion.

I still think that removing the first separator would have made more sense. If you want to add a separator before the page links, you can easily use the before argument.

But if you don't want to have a separator prepended, you need to filter the output via the wp_link_pages filter, which seems like a lot of work for the desired result.

[nacin]

I'd agree the initial separator is weird.

[obenland]

Frank, would you mind refreshing the patch with braces?

[obenland]

Tested and ready to go.

[SergeyBiryukov]

The issue is that themes rely on that initial separator. With the patch, there's no space between "Pages:" and the first number in both Twenty Ten​ and Twenty Twelve​.

If two of our bundled themes rely on it, I guess there are much more in the repository that do the same.

[obenland]

I obviously tested it with the wrong theme. Thanks for your feedback!

[obenland]

24940.4.patch​ goes back to using a blank space before the first link in numbers mode, and only using the separator in next mode, when it's between the two links.

[johnbillion]

I'm happy with this. Just needs a final review.

[johnbillion]

In 30030:

In wp_link_pages(), only output link separators between actual pagination links. Fixes #24940. Props obenland.

[SergeyBiryukov]

In 30035:

Update expected results in wp_link_pages() unit tests after [30030].

see #24940.