WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#24942 closed defect (bug) (fixed)

Deprecate or remove wp_nav_menu_locations_meta_box()

Reported by: SergeyBiryukov Owned by: SergeyBiryukov
Milestone: 3.7 Priority: normal
Severity: minor Version: 3.6
Component: Menus Keywords: has-patch commit
Focuses: Cc:

Description

wp_nav_menu_locations_meta_box() is unused since [23441] and can be deprecated or removed.

Attachments (3)

24942-depr.diff (4.2 KB) - added by DrewAPicture 2 years ago.
deprecate
24942-remove.diff (2.0 KB) - added by DrewAPicture 2 years ago.
remove
24942.2.diff (2.7 KB) - added by SergeyBiryukov 2 years ago.

Download all attachments as: .zip

Change History (8)

@DrewAPicture2 years ago

deprecate

@DrewAPicture2 years ago

remove

comment:1 follow-up: @DrewAPicture2 years ago

  • Keywords has-patch added

+1

Seems like there may have been some confusion before that this callback was being used in the Customizer, which in actuality uses its own nav menus control.

Not sure what the protocol is on removing vs deprecating.

24942-depr.diff deprecates it

24942-remove.diff removes it

comment:2 @SergeyBiryukov2 years ago

  • Milestone changed from Awaiting Review to 3.7

comment:3 in reply to: ↑ 1 @nacin2 years ago

Replying to DrewAPicture:

Not sure what the protocol is on removing vs deprecating.

In this case we should truncate and deprecate it. Avoids fatal errors for anyone somehow calling it, but doesn't keep dead code around.

@SergeyBiryukov2 years ago

comment:4 @SergeyBiryukov2 years ago

  • Keywords commit added

comment:5 @SergeyBiryukov2 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 25209:

Deprecate wp_nav_menu_locations_meta_box(), unused since [23441]. props DrewAPicture. fixes #24942.

Note: See TracTickets for help on using tickets.