Make WordPress Core

Opened 13 years ago

Closed 13 years ago

#24943 closed defect (bug) (fixed)

Twenty Thirteen - broken localization of custom header images

Reported by: pavelevap Owned by: nacin
Priority: normal Milestone: 3.7
Component: Bundled Theme Version: 3.6
Severity: normal Keywords: has-patch commit
Cc: Focuses:

Description

Function twentythirteen_custom_header_setup() is probably called before twentythirteen_setup() and they are related to the same after_setup_theme action. So, twentythirteen textdomain is loaded after twentythirteen_custom_header_setup() and that is why localization of 3 strings (Star, Diamond and Circle) for custom header does not work.

See attached patch (works for me).

Attachments (1)

custom-header-localization.patch (516 bytes ) - added by pavelevap 13 years ago.

Download all attachments as: .zip

Change History (7)

#1 @obenland
13 years ago

  • Keywords has-patch added
  • Milestone Awaiting Review3.7

#2 @SergeyBiryukov
13 years ago

Confirmed the bug and the fix.

#3 @obenland
13 years ago

Another reason I like to aggregate all includes at the end of the functions.php file.

Although setting a priority will always work and would not be depended on the chance of the callback being registered at the right time. :)

#4 @SergeyBiryukov
13 years ago

  • Keywords commit added

#5 @nacin
13 years ago

Priority is much more reliable than include order.

#6 @nacin
13 years ago

  • Owner set to nacin
  • Resolutionfixed
  • Status newclosed

In 25129:

Twenty Thirteen: Ensure custom headers are set up after the localization is initialized.

props pavelevap.
fixes #24943.

Note: See TracTickets for help on using tickets.