WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 23 months ago

Last modified 23 months ago

#24967 closed enhancement (invalid)

Twenty Fourteen: Add ID to comment for closing div in sidebar.php

Reported by: Jonnyauk Owned by:
Milestone: Priority: normal
Severity: minor Version: 3.8
Component: Bundled Theme Keywords:
Focuses: Cc:

Description

I have noticed that most of the closing div's in Twenty Fourteen have their ID and class in a code comment (which is nice!) - see the patch attached for a proposed amendment to sidebar.php with the class added to the closing div for consistency.

Attachments (1)

1.patch (439 bytes) - added by Jonnyauk 2 years ago.
v1 patch file for sidebar.php

Download all attachments as: .zip

Change History (3)

@Jonnyauk2 years ago

v1 patch file for sidebar.php

comment:1 @lancewillett23 months ago

  • Keywords has-patch removed
  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

Thanks Jonnyauk!

We have a convention for this throughout the template files: if the element has only a class, that is the closing comment. If it has an ID, then we use just the ID.

Noting this was fixed properly with r25023.

comment:2 @Jonnyauk23 months ago

No problem and thanks for your feedback - great to see this theme developing and hope I can make a more substantial contribution in the future to this or core ;)

Note: See TracTickets for help on using tickets.