WordPress.org

Make WordPress Core

Opened 5 years ago

Last modified 3 years ago

#24975 reviewing defect (bug)

Scheduled Page on Menu showing before Schedule time

Reported by: nellyshark Owned by: chriscct7
Milestone: Future Release Priority: normal
Severity: normal Version: 3.6
Component: Menus Keywords: has-patch
Focuses: administration Cc:

Description

Hi all,

I think I have found a bug.

Wordpress 3.6 on Xampp server

Scenario: I create a page (today) and schedule it (example tomorrow, 1 month, several months). When I go to Menus, the page is not in 'Most Recent' or 'View All' tabs. When I search by Page Title I can locate the page & add the page to the Menu. The page is now on the menu and set to schedule on the Dashboard.

Should the page be showing on the menu when it is set to Schedule? Or should the 'Search' only search published pages?

Attachments (3)

24975.patch (1.9 KB) - added by rhyswynne 4 years ago.
24975.2.patch (1.7 KB) - added by rhyswynne 4 years ago.
Recorrected patch tested locally with 4.1-alpha
24975.diff (613 bytes) - added by mattheu 4 years ago.

Download all attachments as: .zip

Change History (14)

#1 @Latz
4 years ago

  • Keywords needs-patch dev-feedback added

Hello nellyshark,

Sorry you never got a response.

I think you're right. The page should appear in "Most Recent" and "View all", maybe marked with (scheduled). I can see no reason why this has been done the way it is now.

Anybody to volunteer for a patch?

#2 @helen
4 years ago

Related: #21773

#3 @SergeyBiryukov
4 years ago

  • Component changed from Date/Time to Menus

@rhyswynne
4 years ago

#5 @rhyswynne
4 years ago

Patch for this if needed. Also works for posts as well as pages. Scheduled label doesn't appear when adding to the menu too.

#6 @rhyswynne
4 years ago

Tested the patch on 4.1-alpha, didn't work. Resubmitted it.

@rhyswynne
4 years ago

Recorrected patch tested locally with 4.1-alpha

#7 @mattheu
4 years ago

  • Keywords has-patch added; needs-patch removed

I tested the issue and can confirm the problem - scheduled posts are not normally visible when adding items to the menu, but are returned by the quicksearch.

I tested the patch by rhyswynne which added a label to indicate that it is scheduled - the problem however is that it still allows you to add a scheduled post to the admin menu - which will then lead to a 404.

This could be taken further to filter 'future' posts from the admin menu, but I think that a simpler solution would be to only return published posts in the menu item quicksearch query as it does for 'most recent' and 'view all'

I have added a patch to fix this.

@mattheu
4 years ago

#8 @johnbillion
4 years ago

  • Keywords close added; dev-feedback removed
  • Milestone changed from Awaiting Review to 4.1

I'm tempted to wontfix this.

While it's odd that a scheduled post appears when performing a search, I can imagine a situation where someone schedules a group of posts or pages, adds them to a menu, and then only adds that menu to a menu position after the posts or pages have published, for expediency.

Or maybe that's a made-up edge case. Thoughts?

#9 @mattheu
4 years ago

Yeah I did think about this but it just doesn't seem quite right. My main concerns are:

  1. Inconsistency - if you should be allowed to add scheduled posts to a menu - they why not include in 'most recent'?
  2. Ability to create a broken menu. The case of someone building the menu in advance is a good one - but equally someone building a menu that includes broken links is highly possible too and I don't like the idea that you can create a broken menu link.

rhyswynne patch added labelling the scheduled posts - this would be a solution that worked with the current functionali this to make things clear to the user.

#10 @johnbillion
4 years ago

  • Keywords close removed
  • Milestone changed from 4.1 to Future Release

#11 @chriscct7
3 years ago

  • Focuses administration added
  • Keywords 2nd-opinion removed
  • Owner set to chriscct7
  • Severity changed from minor to normal
  • Status changed from new to reviewing
Note: See TracTickets for help on using tickets.