WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#24976 closed task (blessed) (fixed)

Implement develop.svn.wordpress.org

Reported by: nacin Owned by:
Milestone: 3.7 Priority: normal
Severity: normal Version: 3.7
Component: General Keywords:
Focuses: Cc:

Description

As enumerated here: http://make.wordpress.org/core/2013/08/06/a-new-frontier-for-core-development/.

This ticket is for the initial implementation. Once fully committed, this ticket will be closed and any issues, suggestions, or improvements can come in new tickets.

Attachments (3)

svn-ignore.patch (976 bytes) - added by azaozz 6 years ago.
trunk-auto-props.patch (510 bytes) - added by azaozz 6 years ago.
trunk-global-ignores.patch (442 bytes) - added by azaozz 6 years ago.

Download all attachments as: .zip

Change History (34)

#1 @nacin
6 years ago

In [25001]:

New develop.svn.wordpress.org repository based on the old core.svn repository.

  • All WordPress files move to a src/ directory.
  • New task runner (Grunt), configured to copy a built WordPress to build/.
  • svn:ignore and .gitignore for Gruntfile.js, wp-config.php, and node.js.
  • Remove Akismet external from develop.svn. Still exists in core.svn.
  • Drop minified files from src/. The build process will now generate these.

props koop.
see #24976.

and see http://wp.me/p2AvED-1AI.

#2 @nacin
6 years ago

[25001] switched from using YUICompressor (via bumpbot) to UglifyJS2 and clean-css, via Grunt. Hence, the sync commit to core.svn is modifying every minified file.

#3 @nacin
6 years ago

In 25002:

Initial import of unit-tests repository into develop.svn.wordpress.org.

Imported from https://unit-tests.svn.wordpress.org/trunk@1337

see #24976.

#4 follow-up: @nacin
6 years ago

[25002] added two externals: The pinned but still hefty wpcom-themes external, and the wordpress-importer external.

I am all for us testing the importer as if it were a part of core. But let's remove the wpcom-themes external. I was going to suggest we should rework those tests, but I think we should just ditch the Tests_Theme_ThemeDirLarge tests altogether. WP_Theme solved this problem once and for all in 3.4. And also, because it is a pretty lame test. :-)

#5 @nacin
6 years ago

In 25003:

Import internationalization tools from i18n.svn.wordpress.org.

Imported from https://i18n.svn.wordpress.org/tools/trunk@22088.

see #24976.

#6 in reply to: ↑ 4 @bpetty
6 years ago

Replying to nacin:

I am all for us testing the importer as if it were a part of core. But let's remove the wpcom-themes external. I was going to suggest we should rework those tests, but I think we should just ditch the Tests_Theme_ThemeDirLarge tests altogether. WP_Theme solved this problem once and for all in 3.4. And also, because it is a pretty lame test. :-)

Agreed.

#7 follow-up: @bpetty
6 years ago

Also, in regard to the importer, I think it would also be better if we eventually managed to pull those tests into the plugin itself, and run those tests separately like any other plugin would (also helping set the example for other plugins).

When the dust settles, maybe this is something Frederick might want to look at post GSoC?

#8 @nacin
6 years ago

In 25004:

Remove the legacy Tests_Theme_ThemeDirLarge test to drop the wpcom-themes external/dependency. see #24976.

#9 in reply to: ↑ 7 @nacin
6 years ago

Replying to bpetty:

Also, in regard to the importer, I think it would also be better if we eventually managed to pull those tests into the plugin itself, and run those tests separately like any other plugin would (also helping set the example for other plugins).

That does make sense. I'd want to make sure any importer tests are not neglected, especially in terms of being broken by core changes. We'll probably just want to make sure we hook it up into Travis CI.

#10 @nacin
6 years ago

In 25005:

SCRIPT_DEBUG is no longer needed when using develop.svn's src/ directory. see #24976.

#11 @nacin
6 years ago

[25005] could be done better, but it works for now.

#12 follow-up: @nacin
6 years ago

I set up a redirect from http://develop.trac.wordpress.org/ to http://core.trac.wordpress.org/.

Additionally, if you go to a /browser/trunk/wp-* URL, with no query string (so no ?rev=12345), it'll redirect you to the proper URL with /src. This should prevent a lot of link rot from elsewhere on Trac, mailing lists, etc.

Example:
http://core.trac.wordpress.org/browser/trunk/wp-admin/ redirects to http://core.trac.wordpress.org/browser/trunk/src/wp-admin/

http://core.trac.wordpress.org/browser/trunk/wp-admin/?rev=25000 does not redirect.

This also works for /log/. And you'll note from the last example that r25000 has some nice practical implications, too — easy to remember.

#13 follow-up: @dd32
6 years ago

I notice a .gitignore was added along side svn:ignore, that in itself isn't an issue, but I noticed that the .gitignore ignores a lot more than than the SVN equivalent, is there any need for us to sync those a bit more?

#14 @dd32
6 years ago

Seems something funny is going on in Trac

For example, on http://core.trac.wordpress.org/browser/trunk/src/wp-includes/admin-bar.php the Blame link lacks the src/ path, however the Previous Revision link works (and it links to the non-src/ url, as that's where the file was at the time).

But then take a file that's been modified since the move, such as http://core.trac.wordpress.org/browser/trunk/src/wp-includes/script-loader.php, and the Blame link is fine, but the Previous Revision link is missing.

#15 @nbachiyski
6 years ago

In 25015:

Use correct path to src/

See #24976

#16 in reply to: ↑ 13 ; follow-up: @azaozz
6 years ago

Replying to dd32:

I noticed that the .gitignore ignores a lot more than the SVN equivalent, is there any need for us to sync those a bit more?

Think so, also perhaps ignore wp-tests-config.php and .htaccess.

#17 in reply to: ↑ 16 @bpetty
6 years ago

Replying to azaozz:

Think so, also perhaps ignore wp-tests-config.php and .htaccess.

I was about to add that, and phpunit.xml, but I'm still waiting on commit access to be transferred over.

#18 follow-up: @azaozz
6 years ago

...and phpunit.xml

Right, with <phpunit colors="true"> PHPUnit is still not clever enough not to output console colors on windows making it look really broken :)

#19 @duck_
6 years ago

In 25040:

Search for wp-util.min.js in the correct directory when auto-defining SCRIPT_DEBUG.

See #24976, [25005].

#20 in reply to: ↑ 18 @SergeyBiryukov
6 years ago

Replying to azaozz:

Right, with <phpunit colors="true"> PHPUnit is still not clever enough not to output console colors on windows making it look really broken :)

ANSICON fixes that for me :)

#21 @scribu
6 years ago

Somewhat related: #25065

#22 @azaozz
6 years ago

The svn-ignore property is not recursive like .gitignore. It applies only to the current directory and doesn't accept sub-directory paths as values.

In Subversion 1.8 (came out about a month ago) there are two new properties: svn:global-ignores and svn:auto-props. Global-ignores is recursive and auto-props can be used to set things like svn:eol-style and svn:mime-type for new files.

Last edited 6 years ago by azaozz (previous) (diff)

@azaozz
6 years ago

#23 @azaozz
6 years ago

svn-ignore.patch adds "old style" svn:ignore to . including .htaccess and *.log, to ./tests and to ./src/wp-content for uploads and blogs.dir.

trunk-global-ignores.patch adds svn:ignore to . for .htaccess and *.log, and svn:global-ignores for wp-config.php, wp-tests-config.php, etc.

trunk-auto-props.patch adds some svn:auto-props for new files.

#24 @nacin
6 years ago

#25117 was marked as a duplicate.

#25 @nacin
6 years ago

In 25173:

Move wp-config-sample.php to the root of develop.svn.

wp-config.php is now created in the root. wp-config-sample.php is properly copied over to the build directory for syncing to core.svn.

Add some ignores.

fixes #25185, see #24976.

#26 in reply to: ↑ 12 @dd32
6 years ago

Replying to nacin:

Additionally, if you go to a /browser/trunk/wp-* URL, with no query string (so no ?rev=12345), it'll redirect you to the proper URL with /src. This should prevent a lot of link rot from elsewhere on Trac, mailing lists, etc.

This has now broken for http://core.trac.wordpress.org/browser/trunk/wp-config-sample.php and wp-tests-config-sample.php after [25173]

Last edited 6 years ago by dd32 (previous) (diff)

#27 @netweb
6 years ago

  • Cc netweb added

#28 @dd32
6 years ago

In 25559:

Add a svn:ignore property to wp-content, wp-content/plugins, and, wp-content/themes to clean up the output of a svn status, this means that plugins/themes/uploads won't clutter the svn status output. Fixes #25337 See #24976

#29 @nacin
6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

This has been working well and we've been making incremental adjustments throughout the cycle. New tickets for any further issues or improvements.

#30 @dd32
6 years ago

In 25704:

Add a svn:ignore property to wp-content for wp-content/languages See [25559] See #25337 See #24976

#31 @SergeyBiryukov
6 years ago

  • Version changed from trunk to 3.7
Note: See TracTickets for help on using tickets.