Opened 10 years ago
Closed 7 years ago
#24988 closed enhancement (maybelater)
Cleanup for `/wp-admin/js/accordion.js`
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 3.8 |
Component: | General | Keywords: | has-patch needs-refresh needs-docs |
Focuses: | javascript | Cc: |
Description
I've attached a cleanup iteration of the existing accordion file.
- Cleaner function names
- Moved the structure of the file to a revealing module pattern
- Added JSDocs
- prefixed jQuery objects with proper
$
sign - The current iteration has no publicly exposed API methods but I was thinking it might be nice to offer support for
toggleAccordion
etc. Need thoughts on this.
Could use a second pair of eyes to test this functionality and make sure we have no errors here.
Attachments (1)
Change History (7)
This ticket was mentioned in Slack in #docs by morganestes. View the logs.
7 years ago
#6
@
7 years ago
- Milestone Awaiting Review deleted
- Resolution set to maybelater
- Status changed from assigned to closed
I tried refreshing the existing patch, but it's diverged so much over the years that it doesn't make sense anymore. I'm going to say we close it for now, and if someone wants to revisit this, then we can reopen it then.
Note: See
TracTickets for help on using
tickets.
Looks like accordion-cleanup.diff is a good start. Would you mind adding a file header? I believe we added this in the last cycle (3.6).