WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#24989 closed defect (bug) (fixed)

Cleanup for `/wp-admin/js/cat.js`

Reported by: carldanley Owned by: ocean90
Milestone: 3.7 Priority: normal
Severity: normal Version:
Component: General Keywords:
Focuses: Cc:
PR Number:

Description

Can this functionality be moved to a WP utilities file or something? Seems a little crazy to include a file for 5 lines of JS.

Attachments (2)

24989.patch (949 bytes) - added by ocean90 6 years ago.
24989.2.patch (2.8 KB) - added by carldanley 6 years ago.

Download all attachments as: .zip

Change History (6)

#1 @ocean90
6 years ago

  • Milestone changed from Awaiting Review to 3.7

The handle of the file is ajaxcat. Seems like it's not even used in core.

There is also a typo in the ID selector: $('#jaxcat'). Coudn't find any reference to jaxcat or ajaxcat.

So, let's remove it?

#2 @rmccue
6 years ago

This was made redundant in r6588 as part of #5618 for 2.5. The last core usage was removed in r6695. (via git log -Sjaxcat -p)

+1 for removal.

@ocean90
6 years ago

@carldanley
6 years ago

#3 @helen
6 years ago

ocean90 - seems like you removed the bad ref from $_old_files but didn't replace it.

#4 @ocean90
6 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 25020:

Remove unused cat JavaScript file. props carldanley. fixes #24989.

Note: See TracTickets for help on using tickets.