WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #24990, comment 7


Ignore:
Timestamp:
10/07/2014 02:31:23 PM (5 years ago)
Author:
pputzer
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #24990, comment 7

    initial v1  
    22> I'm not sure what's the issue with calling `do_shortcode` for the caption, whether it's set via the media popup or as an attribute, so a simple call added to the caption callback.
    33
    4 I'm pretty sure that this patch does not help at all. The problem is the regex line {{{if ( preg_match( '#((?:<a [^>]+>\s*)?<img [^>]+>(?:\s*</a>)?)(.*)#is', $content, $matches ) ) {}}} that throws out any shortcode enclosing the image and/or link tag in the {{{$content}}}.
     4I'm pretty sure that this patch is only a partial fix. The problem is the regex line {{{if ( preg_match( '#((?:<a [^>]+>\s*)?<img [^>]+>(?:\s*</a>)?)(.*)#is', $content, $matches ) ) {}}} that throws out any shortcode enclosing the image and/or link tag in the {{{$content}}}.