Make WordPress Core

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#24999 closed defect (bug) (fixed)

The 'wpeditimage' TinyMCE plugin is broken in trunk/src

Reported by: azaozz's profile azaozz Owned by: azaozz's profile azaozz
Milestone: 3.7 Priority: normal
Severity: normal Version: 3.7
Component: TinyMCE Keywords:
Focuses: Cc:

Description

The dialog iframe html is static, and the hard-coded js/editimage.min.js file doesn't exist in trunk/src/.

Only this custom TinyMCE plugin is affected as it's the only one that includes JS in a static html file. The default TinyMCE plugins don't use minified JS in these cases.

Attachments (1)

24999.patch (2.0 KB) - added by azaozz 12 years ago.

Download all attachments as: .zip

Change History (6)

@azaozz
12 years ago

#1 @azaozz
12 years ago

There are three options to fix this:

  • Add the whole editimage.js in the html head. The JS will be cached as part of the static html file.
  • Remove the minified editimage.min.js and always use editimage.js.
  • Pass a hash to the html and use it to select which file to load, 24999.patch.

The first seems the most straightforward. The third has to use document.write as the JS has to load synchronously (the next JS file depends on this one).

#2 @azaozz
12 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 25022:

TinyMCE: always use js/editimage.js in the custom 'editimage' plugin, same way as the default TinyMCE plugins. Fixes #24999.

#3 @nacin
12 years ago

In 25897:

Add editimage.min.js to $_old_files. see #24999.

#4 @nacin
12 years ago

In 25898:

Add editimage.min.js to $_old_files. see #24999. for the 3.7 branch.

#5 @SergeyBiryukov
12 years ago

  • Version changed from trunk to 3.7
Note: See TracTickets for help on using tickets.