WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#25028 closed feature request (fixed)

Twenty Fourteen: widgetize the Post Format front page so other widgets can go there, and Post Format widgets can be used in other sidebars

Reported by: paolal Owned by:
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Bundled Theme Keywords:
Focuses: Cc:

Description

Instead of hardcoding the home sidebar to show two posts for each non standard format in a fixed order, widgetize it and create a widget to show any number of any post format with a custom title.

In addition to more control on the homepage, this widget would also allow the sidebar on other pages to remain identical.

Attachments (3)

25028.diff (28.2 KB) - added by obenland 8 years ago.
25028.1.diff (27.2 KB) - added by obenland 8 years ago.
25028.2.diff (26.9 KB) - added by obenland 8 years ago.

Download all attachments as: .zip

Change History (19)

#1 @cainm
8 years ago

  • Cc cain@… added

#2 @MikeHansenMe
8 years ago

  • Cc mdhansen@… added

#3 @SergeyBiryukov
8 years ago

  • Component changed from General to Bundled Theme

#4 @obenland
8 years ago

Yes, I was working on a widget, modeled a bit after Twenty Eleven's Ephemera Widget. Patch coming shortly.

#5 @obenland
8 years ago

  • Milestone changed from Awaiting Review to 3.8
  • Version set to trunk

#6 @iamtakashi
8 years ago

  • Cc takashi@… added

#7 @trishasalas
8 years ago

  • Cc trisha@… added

@obenland
8 years ago

#8 follow-up: @obenland
8 years ago

  • Keywords has-patch added

There are still some decisions to be made:

  • Do we keep the sidebar on the front page exclusive to formatted posts?
    • If we do, what order should the widgets have?
  • Do we offer an option to change the amount of posts within the ephemera widget?

#9 in reply to: ↑ 8 @lancewillett
8 years ago

Replying to obenland:

  • Do we keep the sidebar on the front page exclusive to formatted posts?

I don't think so. Allow any widget to be added there.
Or, it could be that if you add any other widget, they disappear.

  • If we do, what order should the widgets have?

Let them be re-ordered?

  • Do we offer an option to change the amount of posts within the ephemera widget?

Yes, that'd be a nice addition.

@obenland
8 years ago

#10 @obenland
8 years ago

Updated patch.

#11 @lancewillett
8 years ago

Patch is looking good, I did make one change, adding esc_attr() on lines 237 and 238 of inc/widgets.php for outputting attributes.

#12 @lancewillett
8 years ago

  • Summary changed from Twenty Fourteen: give more control on the home sidebar to Twenty Fourteen: widgetize the Post Format front page so other widgets can go there, and Post Format widgets can be used in other sidebars

#13 @lancewillett
8 years ago

PHP warning when adding the Ephemera widget to a sidebar: Notice: Undefined index: format in wp-content/themes/twentyfourteen/inc/widgets.php on line 232

@obenland
8 years ago

#14 @lancewillett
8 years ago

In 25090:

Twenty Fourteen: widgetize the Post Format front page so other widgets can be used there, and the special Post Format content can be used in other widget areas. Props obenland, see #25028.

#15 @lancewillett
8 years ago

  • Keywords has-patch removed
  • Resolution set to fixed
  • Status changed from new to closed

Closing, open new issues in new tickets.

#16 @lancewillett
8 years ago

In 25814:

Twenty Fourteen: cleanup, props iamtakashi. Fixes #25613.

  • With the ephemera widget in place, content-recent-formatted-post.php is unused, see #25028.
  • We're no longe filtering formatted posts from the main query, see #25330.
    • Fix a typo.
Note: See TracTickets for help on using tickets.