WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#25045 closed enhancement (fixed)

Twenty Fourteen: Use HTML5 comment markup

Reported by: obenland Owned by: lancewillett
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:
PR Number:

Description

Eventually we should move to completely support the core HTML5. Let's start with the comment markup.

Attachments (4)

25045.diff (6.3 KB) - added by obenland 6 years ago.
25045.1.diff (9.8 KB) - added by obenland 6 years ago.
25045.patch (1.2 KB) - added by Jayjdk 6 years ago.
Add url to the list of input selectors
25045.2.diff (5.2 KB) - added by iamtakashi 6 years ago.
Style adjustments for the new HTML5 comment markup. And minor bug fixes for comment responsive pattern.

Download all attachments as: .zip

Change History (10)

@obenland
6 years ago

#1 @MikeHansenMe
6 years ago

  • Keywords has-patch added

#2 @lancewillett
6 years ago

@obenland Can you refresh this patch? The CSS didn't apply cleanly.

@obenland
6 years ago

#3 @obenland
6 years ago

Refreshed patch.

While ready for commit, Takashi still needs to decide on how to deal with the reply link.

#4 @lancewillett
6 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 25087:

Twenty Fourteen: Use HTML5 comment markup, props obenland. Fixes #25045.

#5 @Jayjdk
6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

The URL input type needs styling. Patch attached.

@Jayjdk
6 years ago

Add url to the list of input selectors

@iamtakashi
6 years ago

Style adjustments for the new HTML5 comment markup. And minor bug fixes for comment responsive pattern.

#6 @lancewillett
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 25216:

Twenty Fourteen: style adjustments for the new HTML5 comment markup, and minor bug fixes for comment responsive pattern. Props iamtakashi, fixes #25045.

Note: See TracTickets for help on using tickets.