WordPress.org

Make WordPress Core

Opened 8 months ago

Closed 8 months ago

Last modified 8 months ago

#25046 closed enhancement (fixed)

is_email_address_unsafe should be case insensitve

Reported by: jkudish Owned by: nacin
Milestone: 3.6.1 Priority: normal
Severity: normal Version:
Component: Multisite Keywords: has-patch
Focuses: Cc:

Description

is_email_address_unsafe should be case insensitive

For example: if I add superhacker.com to the list of banned domains, SuperHacker.com should not be allowed either.

Attached patch fixes the problem.

Attachments (2)

25046.diff (607 bytes) - added by jkudish 8 months ago.
25046-tests.diff (1.3 KB) - added by jkudish 8 months ago.
Adding some tests to go along with the fix

Download all attachments as: .zip

Change History (8)

jkudish8 months ago

comment:1 helen8 months ago

  • Keywords needs-unit-tests added

comment:2 nacin8 months ago

  • Milestone changed from Awaiting Review to 3.7

Well that's kind of pathetic.

comment:3 jkudish8 months ago

  • Keywords needs-unit-tests removed

jkudish8 months ago

Adding some tests to go along with the fix

comment:4 nacin8 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 25197:

Case insensitivity for is_email_address_unsafe().

props jkudish.
fixes #25046.

comment:5 nacin8 months ago

In 25198:

Case sensitivity for is_email_address_unsafe().

Merges [25197] to the 3.6 branch.

props jkudish.
fixes #25046.

comment:6 nacin8 months ago

  • Milestone changed from 3.7 to 3.6.1
Note: See TracTickets for help on using tickets.