Wrong time displayed for restored posts

[pavelevap]

There is a message "Previously restored by..." displayed in Revisions admin metabox when post was restored. Value for $time_diff is right, but $date is wrong. It shows current date everytime and not the date of restoration. Problem is related to $restored_from_meta[ 'restored_time' ] which is Unix timestamp and not string. So, strtotime() does not make sense here...

Attached is a simple patch to illustrate described issue. It works for me, but I am not familiar with date/time functions, maybe there is better solution...

[nacin]

Per IRC, the plan here is to actually remove this whole section of the revisions box. It's ugly, not very useful, and is in a box we want to get rid of anyway. We're not going to prevent collecting the data, just remove the UI.

[nacin]

In 25194:

Remove display of 'Previously restored by' in the revisions meta box as it is busted.

Fixes invalid markup (missing closing ul tag) when there was no previously restored revision.

see #25051 for trunk.

[nacin]

From IRC:

Sergey: What's the plan for 3.6 on #25051? restoration.time.patch seems fine, should I test it?

Nacin: I think it should be what I committed ([25194]), but if the patch works, I guess we can just do that. (also need to move the </ul> out from the if statement.)

[SergeyBiryukov]

We could probably keep date_i18n(), see 25051.patch​. But I'm fine with [25194] too.

[pavelevap]

Yes, removing the whole section is the best option, I guess (also for 3.6.1).

[nacin]

In 25233:

Remove display of 'Previously restored by' in the revisions meta box as it is busted.

Fixes invalid markup (missing closing ul tag) when there was no previously restored revision.

Merges [25194] to the 3.6 branch.
fixes #25051.