Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#25058 closed enhancement (wontfix)

Gallery Settings should follow image_default_link_type

Reported by: lkraav Owned by:
Milestone: Priority: normal
Severity: normal Version: 2.7
Component: Gallery Keywords:
Focuses: Cc:

Description (last modified by SergeyBiryukov)

media.php L1906+ has default gallery link type hardcoded. This should be configurable so customers (esp. WordPress newcomers) wouldn't have to worry about it each time they create a new gallery and I wouldn't have to waste time with various magic checking and overriding it.

Planning to patch this at some point, unless I get arguments here not to do it or somebody plain beats me to it.

Change History (4)

#1 @SergeyBiryukov
5 years ago

  • Description modified (diff)

#2 @SergeyBiryukov
5 years ago

  • Version changed from 3.6 to 2.7

The code in question was introduced in [9894], so this appears to be related to the old media UI.

#3 follow-up: @nacin
5 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

The new UI appears to obey the user setting (half-meta, half-cookie). I don't think we should listen to image_default_link_type site-wide option here, which only exists for backwards compatibility and cannot be set via the UI. Suddenly obeying this for galleries could have other effects.

#4 in reply to: ↑ 3 @lkraav
5 years ago

Replying to nacin:

The new UI appears to obey the user setting (half-meta, half-cookie).

What setting are you referring to? "new UI" refers to something in trunk? I only checked 3.6 so far.

Note: See TracTickets for help on using tickets.