WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 7 weeks ago

#25060 assigned defect (bug)

Quick Edit Comments inline edit save breaks the alternating table row backgrounds

Reported by: c3mdigital Owned by: helen
Milestone: Future Release Priority: normal
Severity: normal Version: 3.1
Component: Quick/Bulk Edit Keywords: has-patch
Focuses: ui, javascript, administration Cc:

Description

Related: #24951
Related: #25059

When quick editing comments and saving the single_row method always uses the same classes "even thread-even". Additionally a css background color gets added to the table row inline.

This patch fixes the class issues. Still need a patch for the background color.

Attachments (5)

25060.patch (1.0 KB) - added by c3mdigital 3 years ago.
25060.2.patch (1.5 KB) - added by c3mdigital 3 years ago.
Fixes inline background-color and classes
25060.3.patch (1.4 KB) - added by c3mdigital 3 years ago.
tabs not spaces
25060.4.patch (3.0 KB) - added by c3mdigital 3 years ago.
Replace javascript hex color background animations with class change animations
25060.diff (2.7 KB) - added by helen 16 months ago.

Download all attachments as: .zip

Change History (20)

@c3mdigital
3 years ago

#1 @c3mdigital
3 years ago

  • Keywords needs-refresh removed

@c3mdigital
3 years ago

Fixes inline background-color and classes

#2 @nacin
3 years ago

  • Milestone changed from Awaiting Review to 3.7
  • Owner set to helen
  • Status changed from new to assigned

@c3mdigital
3 years ago

tabs not spaces

#3 follow-up: @helen
3 years ago

We have hex values set in JS? :( :( :(

#4 in reply to: ↑ 3 ; follow-up: @c3mdigital
3 years ago

Replying to helen:

We have hex values set in JS? :( :( :(

Yes I almost cried too. They are really just used for the green background on un approved comments. Maybe we should be adding a class and update the css?

Version 0, edited 3 years ago by c3mdigital (next)

#5 in reply to: ↑ 4 @helen
3 years ago

Replying to c3mdigital:

Yes please pretty please.

@c3mdigital
3 years ago

Replace javascript hex color background animations with class change animations

#6 @helen
3 years ago

Been fighting with this - latest patch breaks the visual change of parent comment approval when you approve and reply inline.

More than that, though, the zebra striping has issues other than just editing inline - replying inline causes everything to be off. We can still fix this piece of the problem, but just wanted to note that there's more to the entire picture.

#7 @nacin
3 years ago

  • Milestone changed from 3.7 to Future Release

Moving based on Helen's observations.

#8 @helen
3 years ago

This is a place where using :nth-child selectors in CSS would work out way better. IE7 and 8 would just not get zebra striping anymore.

#9 @helen
16 months ago

  • Milestone changed from Future Release to 4.2

@helen
16 months ago

#10 @helen
16 months ago

Opened #31006 to handle the background hex values in JS thing, as it happens outside of comments as well - will continue off of your start, c3mdigital.

#11 @helen
16 months ago

In 31181:

List tables: Use CSS :nth-child() selectors for zebra striping.

Note that this does not fix issues related to comment quick edit. Internal linking also continues to use the .alternate class for now. IE8 and below gracefully degrade by not having zebra striping.

There is some hoop jumping with adding an extra table row to maintain zebra striping during quick edit. Documenting that here for future reference; it is also in the inline documentation.

fixes #30981 and #26060. see #25060.

#12 follow-up: @DrewAPicture
14 months ago

Based on [31181], looks like this issue still hasn't been resolved for comments quick edit. @helen: Did you still want to try to resolve this for 4.2?

#13 in reply to: ↑ 12 @helen
14 months ago

Replying to DrewAPicture:

Did you still want to try to resolve this for 4.2?

That's what #31006 is for - this relies on that.

#14 @helen
13 months ago

  • Focuses ui javascript administration added
  • Milestone changed from 4.2 to Future Release

Still blocked, too much to be doing at this point in 4.2. A comments-list-table-only solution could be done, but I think that would put us in a bad position later.

This ticket was mentioned in Slack in #core by obenland. View the logs.


7 weeks ago

Note: See TracTickets for help on using tickets.