WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 2 of Ticket #25061


Ignore:
Timestamp:
08/17/2013 07:07:48 PM (11 years ago)
Author:
SergeyBiryukov
Comment:

Turned stream_body_hack.txt​ into a patch: 25061.patch​.

We have a similar check in _unzip_file_pclzip(): tags/3.6/wp-admin/includes/file.php#L669​ (introduced in [17592]) and POMO_Reader: tags/3.6/wp-includes/pomo/streams.php#L17​ (introduced in [11626]).

Related: #18007 (explores other options to deal with mbstring.func_overload).

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #25061

    • Property Severity changed from normal to major
    • Property Milestone changed from Awaiting Review to 3.6.1

  • Ticket #25061 – Description

    initial v2  
    11When downloading an update in the form of a zip file the update consistently fails with a failure to find the end of central dir record when unpack is attempted. For example:
    2 
     2{{{
    33Downloading update from http://downloads.wordpress.org/plugin/addthis.3.5.1.zip…
    44
    … …  
    66
    77The package could not be installed. PCLZIP_ERR_BAD_FORMAT (-10) : Unable to find End of Central Dir Record signature
    8 
     8}}}
    99The download is using curl.
    1010
    1111To reproduce add the following to PHP configuration:
    12 
     12{{{
    1313mbstring.func_overload = 2;
    14 
     14}}}
    1515which enables str*() function overloading.
    1616