WordPress.org

Make WordPress Core

#25063 closed defect (bug) (fixed)

Correct check for mbstring.func_overload in _unzip_file_pclzip()

Reported by: SergeyBiryukov Owned by: dd32
Milestone: 3.7 Priority: normal
Severity: normal Version: 3.2
Component: Filesystem API Keywords: has-patch
Focuses: Cc:

Description

Background: #25061

[17592] added a fix to _unzip_file_pclzip() for mbstring.func_overload (see #15789).

However, it does not check that the value of mbstring.func_overload actually redefines string functions and not mail() or regex functions. See POMO_Reader() for the correct check: tags/3.6/wp-includes/pomo/streams.php#L17.

Attachments (1)

25063.patch (674 bytes) - added by SergeyBiryukov 20 months ago.

Download all attachments as: .zip

Change History (3)

@SergeyBiryukov20 months ago

comment:1 @dd3220 months ago

Confirmed that PclZip doesn't make use of any eregi-related functions, so & 2 is safe (The alternative as & 6 to support both).

comment:2 @dd3220 months ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 25056:

Check to see if mbstring.func_overload is configured to affect string functions before switching charsets. Props SergeyBiryukov. Fixes #25063

Note: See TracTickets for help on using tickets.