Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#25074 closed defect (bug) (fixed)

Incorrect documentation about HTTP/1.1 support

Reported by: leewillis77 Owned by: dd32
Milestone: 3.7 Priority: normal
Severity: normal Version: 3.6
Component: Inline Docs Keywords: has-patch
Focuses: Cc:


The initial set of comments in wp-includes/class-http.php states:

"Handles [...] chunk decoding, if HTTP 1.1" http://core.trac.wordpress.org/browser/trunk/src/wp-includes/class-http.php#L5

However, later on, the comments claim "Version 1.1 is not supported, because of chunk response" http://core.trac.wordpress.org/browser/trunk/src/wp-includes/class-http.php#L58

I think that 1.1 is supported, as is chunk decoded - http://core.trac.wordpress.org/browser/trunk/src/wp-includes/class-http.php#L469

If that's the case, then the documentation should be updated as per the attached patch.

Attachments (1)

25074.diff (1.0 KB) - added by leewillis77 5 years ago.
Documentation update patch

Download all attachments as: .zip

Change History (7)

5 years ago

Documentation update patch

#1 @leewillis77
5 years ago

  • Keywords has-patch added

#2 @leewillis77
5 years ago

  • Component changed from Comments to HTTP

#3 @SergeyBiryukov
5 years ago

  • Component changed from HTTP to Inline Docs
  • Milestone changed from Awaiting Review to 3.7

#4 @nacin
5 years ago

  • Owner set to dd32
  • Status changed from new to assigned

#5 @dd32
5 years ago

The docs are wrong, yet, right at the same time. We don't support HTTP/1.1 since it's untested and mostly broken. We support chunked decoding, but it's broken, so we don't actually "support" it.

This really goes hand-in-hand with #23463

#6 @dd32
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 25154:

WP_HTTP: Update the documentation regarding HTTP/1.1 support. Props leewillis77 Fixes #25074

Note: See TracTickets for help on using tickets.