Make WordPress Core

Context Navigation

← Previous Ticket
Next Ticket →

Opened 13 years ago

Closed 13 years ago

#25074 closed defect (bug) (fixed)

Incorrect documentation about HTTP/1.1 support

Reported by:	leewillis77	Owned by:	dd32
Priority:	normal	Milestone:	3.7
Component:	Inline Docs	Version:	3.6
Severity:	normal	Keywords:	has-patch
Cc:		Focuses:

Description

The initial set of comments in wp-includes/class-http.php states:

"Handles [...] chunk decoding, if HTTP 1.1"
http://core.trac.wordpress.org/browser/trunk/src/wp-includes/class-http.php#L5

However, later on, the comments claim "Version 1.1 is not supported, because of chunk response"
http://core.trac.wordpress.org/browser/trunk/src/wp-includes/class-http.php#L58

I think that 1.1 is supported, as is chunk decoded - http://core.trac.wordpress.org/browser/trunk/src/wp-includes/class-http.php#L469

If that's the case, then the documentation should be updated as per the attached patch.

Attachments (1)

25074.diff (1.0 KB ) - added by leewillis77 13 years ago.: Documentation update patch

Download all attachments as: .zip

Change History (7)

@leewillis77
13 years ago

Attachment 25074.diff added

Documentation update patch

#1 @leewillis77
13 years ago

Keywords has-patch added

#2 @leewillis77
13 years ago

Component Comments → HTTP

#3 @SergeyBiryukov
13 years ago

Component HTTP → Inline Docs
Milestone Awaiting Review → 3.7

#4 @nacin
13 years ago

Owner set to dd32
Status new → assigned

#5 @dd32
13 years ago

The docs are wrong, yet, right at the same time.
We don't support HTTP/1.1 since it's untested and mostly broken.
We support chunked decoding, but it's broken, so we don't actually "support" it.

This really goes hand-in-hand with #23463

#6 @dd32
13 years ago

Resolution → fixed
Status assigned → closed

WP_HTTP: Update the documentation regarding HTTP/1.1 support. Props leewillis77 Fixes #25074

Note: See TracTickets for help on using tickets.

Download in other formats: