WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#25078 closed defect (bug) (fixed)

Unwanted global variable in media-models.js

Reported by: greuben Owned by: SergeyBiryukov
Milestone: 3.7 Priority: normal
Severity: minor Version: 3.5
Component: Media Keywords: has-patch
Focuses: Cc:

Description

How to reproduce?

  1. Open media library (browser)
  2. args variable is exposed to global space in line 696 of media-models.js

Attachments (1)

fix.diff (462 bytes) - added by greuben 2 years ago.

Download all attachments as: .zip

Change History (3)

@greuben2 years ago

comment:1 @SergeyBiryukov2 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.7

comment:2 @SergeyBiryukov2 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 25080:

Declare args as a local variable. props greuben. fixes #25078.

Note: See TracTickets for help on using tickets.