WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#2508 closed enhancement (fixed)

Make Comment Purging Warning More Informative

Reported by: schestowitz Owned by: robmiller
Milestone: 2.1 Priority: lowest
Severity: normal Version: 2.0
Component: Administration Keywords: bg|has-patch bg|tested bg|commit
Focuses: Cc:

Description

(nightly 25-02-2006) When viewing comments in 'mass edit' mode, deletion of comments is a common and risky task. However, the prompt that appears when deleting all selected items does not include the number of selected items. I suggest making it more verbose. User confidence and usability could be improved here, in line with other applications, e.g. mail clients.

Attachments (2)

edit-comments.php.diff (1.6 KB) - added by robmiller 8 years ago.
edit-comments.php.2.diff (1.6 KB) - added by robmiller 8 years ago.
Second patch implementing checking for no checkboxes checked (check!)

Download all attachments as: .zip

Change History (12)

robmiller8 years ago

comment:2 robmiller8 years ago

Patch working fine on my local install.

There's a minor issue, I guess, with the plural form of "comment" when deleting just one comment, although why a user would check use the mass editing mode to delete just one comment I don't know.

Also, whilst changing this it struck me as a bit strange that the form can be submitted when there are 0 comments checked. Perhaps with this new functionality we can do

if(numchecked == 0) return false; else return confirm("blah blah...");

?

robmiller8 years ago

Second patch implementing checking for no checkboxes checked (check!)

comment:3 robmiller8 years ago

Second patch added that alerts the user if there are no checkboxes selected when they try to mass-delete.

comment:4 robmiller8 years ago

  • Milestone set to 2.1

comment:5 robmiller8 years ago

  • Keywords bg|has-patch added; comment moderation removed

comment:6 robmiller8 years ago

  • Owner changed from anonymous to robmiller
  • Status changed from new to assigned

comment:7 davidhouse8 years ago

  • Keywords bg|tested bg|commit added

comment:8 schestowitz8 years ago

Thanks for the patch, Rob.

comment:9 robmiller8 years ago

May it be the first of many, hopefully :)

comment:10 ryan8 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [3652]) Show number of comments selected for deletion. Props robmiller. fixes #2508

Note: See TracTickets for help on using tickets.