WordPress.org

Make WordPress Core

Opened 11 months ago

Closed 6 months ago

#25086 closed defect (bug) (wontfix)

Combine author and gravatar to translatable string

Reported by: pavelevap Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.6
Component: I18N Keywords: has-patch close
Focuses: Cc:

Description

String "%s is currently editing" is related to author, but gravatar icon is hardcoded before this string, so translators are unable to move "%s" variable within this string.

See: http://core.trac.wordpress.org/browser/tags/3.6/wp-admin/includes/class-wp-posts-list-table.php#L572

Not sure about the best solution.

Attachments (2)

25086.diff (1.2 KB) - added by brianhall 10 months ago.
25086.2.diff (1.2 KB) - added by SergeyBiryukov 10 months ago.

Download all attachments as: .zip

Change History (12)

comment:1 SergeyBiryukov11 months ago

  • Milestone changed from Awaiting Review to 3.7

brianhall10 months ago

comment:2 brianhall10 months ago

First pass, coupling the avatar and username together so that %s can be moved around in the requested translation.

This is my first patch, so please let me know if I'm doing something incorrectly - I'm a fast learner, promise. :)

Last edited 10 months ago by brianhall (previous) (diff)

SergeyBiryukov10 months ago

comment:3 follow-up: SergeyBiryukov10 months ago

  • Keywords has-patch commit added

25086.2.diff builds on 25086.diff with a few changes:

  • <span class="locked-avatar"> only contains the avatar, as it does currently.
  • <span class="locked-text"> is removed, since it appears to be redundant as a second wrapper.
  • I guess the string doesn't need escaping (per ticket:19712:5), we should probably only escape display_name.

comment:4 in reply to: ↑ 3 ; follow-up: azaozz10 months ago

Replying to SergeyBiryukov:

  • <span class="locked-text"> is removed, since it appears to be redundant as a second wrapper.

This span is used to add that text with heartbeat. Non-essential, but makes it easier/cleaner.

Not sure what is the exact user case here. Seems core is showing avatars to the left (right for RTL) in many places. Showing it in the middle of a string would make this look awkward? In some languages that string will look like Currently is %s editing or Editing currently is %s.

Also note that avatars can be disabled, so this should look/work well when no avatar.

Last edited 10 months ago by azaozz (previous) (diff)

comment:5 in reply to: ↑ 4 SergeyBiryukov10 months ago

Replying to azaozz:

This span is used to add that text with heartbeat. Non-essential, but makes it easier/cleaner.

Thanks, looks like a new patch is needed to take that into account.

Not sure what is the exact user case here.

Some languages use different word order, depending on the logical stress. I guess that might be the case here.

comment:6 follow-up: azaozz10 months ago

  • Keywords ui-feedback added

Some languages use different word order, depending on the logical stress. I guess that might be the case here.

Right, but that doesn't require having the avatar in the middle of the string. The avatar represents the whole string. After the users have read that few times, they only need to glance at the avatar and not read the text again to comprehend it.

Thinking this should be 'wontfix'. Changing the avatar position would look awkward and reduce usability a bit.

comment:7 SergeyBiryukov10 months ago

  • Keywords commit removed

comment:8 pavelevap10 months ago

Interesting idea, but then it should be changed throughout the core? Some strings are bundled with gravatar placeholder (and movable) and some strings not...

comment:9 in reply to: ↑ 6 nacin9 months ago

  • Keywords close added
  • Milestone changed from 3.7 to Awaiting Review

Replying to azaozz:

Some languages use different word order, depending on the logical stress. I guess that might be the case here.

Right, but that doesn't require having the avatar in the middle of the string. The avatar represents the whole string. After the users have read that few times, they only need to glance at the avatar and not read the text again to comprehend it.

Thinking this should be 'wontfix'. Changing the avatar position would look awkward and reduce usability a bit.

I agree with this. There's no need for the avatar to move with the name in this string in this case.

pavelevap, I'd have to see what other situations you are referring to. This seems like a case-by-case basis.

comment:10 helen6 months ago

  • Keywords ui-feedback removed
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Sounds like consensus to close.

Note: See TracTickets for help on using tickets.