Opened 11 years ago
Closed 11 years ago
#25086 closed defect (bug) (wontfix)
Combine author and gravatar to translatable string
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 3.6 |
Component: | I18N | Keywords: | has-patch close |
Focuses: | Cc: |
Description
String "%s is currently editing" is related to author, but gravatar icon is hardcoded before this string, so translators are unable to move "%s" variable within this string.
Not sure about the best solution.
Attachments (2)
Change History (12)
#3
follow-up:
↓ 4
@
11 years ago
- Keywords has-patch commit added
25086.2.diff builds on 25086.diff with a few changes:
<span class="locked-avatar">
only contains the avatar, as it does currently.<span class="locked-text">
is removed, since it appears to be redundant as a second wrapper.- I guess the string doesn't need escaping (per ticket:19712:5), we should probably only escape
display_name
.
#4
in reply to:
↑ 3
;
follow-up:
↓ 5
@
11 years ago
Replying to SergeyBiryukov:
<span class="locked-text">
is removed, since it appears to be redundant as a second wrapper.
This span is used to add that text with heartbeat. Non-essential, but makes it easier/cleaner.
Not sure what is the exact user case here. Seems core is showing avatars to the left (right for RTL) in many places. Showing it in the middle of a string would make this look awkward? In some languages that string will look like Currently is %s editing
or Editing currently is %s
.
Also note that avatars can be disabled, so this should look/work well when no avatar.
#5
in reply to:
↑ 4
@
11 years ago
Replying to azaozz:
This span is used to add that text with heartbeat. Non-essential, but makes it easier/cleaner.
Thanks, looks like a new patch is needed to take that into account.
Not sure what is the exact user case here.
Some languages use different word order, depending on the logical stress. I guess that might be the case here.
#6
follow-up:
↓ 9
@
11 years ago
- Keywords ui-feedback added
Some languages use different word order, depending on the logical stress. I guess that might be the case here.
Right, but that doesn't require having the avatar in the middle of the string. The avatar represents the whole string. After the users have read that few times, they only need to glance at the avatar and not read the text again to comprehend it.
Thinking this should be 'wontfix'. Changing the avatar position would look awkward and reduce usability a bit.
#8
@
11 years ago
Interesting idea, but then it should be changed throughout the core? Some strings are bundled with gravatar placeholder (and movable) and some strings not...
#9
in reply to:
↑ 6
@
11 years ago
- Keywords close added
- Milestone changed from 3.7 to Awaiting Review
Replying to azaozz:
Some languages use different word order, depending on the logical stress. I guess that might be the case here.
Right, but that doesn't require having the avatar in the middle of the string. The avatar represents the whole string. After the users have read that few times, they only need to glance at the avatar and not read the text again to comprehend it.
Thinking this should be 'wontfix'. Changing the avatar position would look awkward and reduce usability a bit.
I agree with this. There's no need for the avatar to move with the name in this string in this case.
pavelevap, I'd have to see what other situations you are referring to. This seems like a case-by-case basis.
First pass, coupling the avatar and username together so that %s can be moved around in the requested translation.
This is my first patch, so please let me know if I'm doing something incorrectly - I'm a fast learner, promise. :)