WP_Post->post_author is not INT

[1994rstefan]

WP_Post->post_author should be a INT not a STRING.

If you have following Code

$post = get_post(123);
if($post->post_author !== wp_get_current_user()->ID)
   echo 'Not your Post';

it will always fail (printing "Not your Post") because wp_get_current_user()->ID is (as I would expect) a INT but $post->post_author is a STRING.

The WordPress Codex and also the inline PHP Documentation says that post_author is a INT.

[nacin]

Duplicate of #22324. The short of it: Not going to change for now.

[hakre]

The WordPress Codex and also the inline PHP Documentation says that post_author is a INT.

Don't trust the map, trust the terrain. So please fix the codex and the comments here as it looks like an documentation issue.

[nacin]

Replying to hakre:

The WordPress Codex and also the inline PHP Documentation says that post_author is a INT.

Don't trust the map, trust the terrain. So please fix the codex and the comments here as it looks like an documentation issue.

You're welcome to fix the Codex, hakre.

I did not notice the documentation report. WP_Post's phpdoc should be changed, yes.

[nacin]

In 25086:

PHPDoc for WP_Post properties. fixes #25092.

[jamescollins]

25092.diff fixes a (minor) typo that was introduced in [25086].

[SergeyBiryukov]

In 25097:

Fix typo in phpdoc. props jamescollins. fixes #25092.

[bcworkz]

Codex revised 22 Aug 13 by Johnbillion

[SergeyBiryukov]

​http://codex.wordpress.org/index.php?title=Class_Reference/WP_Post&diff=134803&oldid=132719

[SergeyBiryukov]

Didn't mean to change the description, not sure what happened here.

[westonruter]

In 62437:

Privacy: Correct type of WP_User_Request::$user_id from int to string/numeric-string.

Also adds numeric-string as richer PHPStan type to WP_Post::$post_author and WP_Post::$comment_count.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/12018.
Follow-up to r25086, r43011.

Props masteradhoc, desrosj, garrett-eclipse, johnbillion, westonruter, apermo, SergeyBiryukov, TZ-Media, andizer, javorszky.
See #22324, #25092, #43443, #43985, #64898.
Fixes #44723.