WordPress.org

Make WordPress Core

Opened 8 months ago

Last modified 8 months ago

#25097 new defect (bug)

Webkit and Moz transition events un-neccessary

Reported by: pat@… Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 3.6
Component: Administration Keywords:
Focuses: ui Cc:

Description

In recent versions of Chrome and Firefox, the vendor prefixes for transitions, animations, and transforms have been removed. This is fine for CSS, but in javascript the vendor-prefixed events fire in addition to the non-prefixed events. This results in transitionend events firing twice in Chrome/Firefox. I'm not sure where this would have an impact in the WP back-end, but I was looking in media-views.js and noticed where the prefixed events are used and thought to myself that it would likely cause an issue somewhere.

Change History (9)

comment:1 helen8 months ago

What versions of those browsers, and what might we need to continue to support for, say, Kindle Fire/Silk?

comment:2 SergeyBiryukov8 months ago

  • Component changed from General to Administration
  • Keywords ui-focus added

comment:3 jorbin8 months ago

the webkit versions need to stay for safari.

the moz versions could possibly go. Support for the prefix free version was added in ff16 (24 is current).

http://caniuse.com/#feat=css-transitions
https://developer.mozilla.org/en-US/docs/Web/CSS/transform

comment:4 ocean908 months ago

Version 0, edited 8 months ago by ocean90 (next)

comment:5 helen8 months ago

If nothing uses -moz- anymore, seems like we could probably drop that. Not -webkit-, though.

comment:6 pat@…8 months ago

Hm, seems we might need to find a solution then to the multiple events firing in Chrome. If the webkit prefix needs to stay, there should be a detect of some sort to ensure that listeners aren't responding to cloned/prefixed events.

comment:7 helen8 months ago

I guess as far as the JS (jQuery-specific?) part goes, I'm not convinced that's a WP bug. Seems like that would affect a lot of sites and apps that support a broader level of browser compat.

comment:8 pat@…8 months ago

I agree, although WP may very well be affected by this behavior, perhaps a patch?

comment:9 helen8 months ago

Not sure what we should patch in core - is there an actual issue here? I don't think we do (or would do) JS on a transition event.

I'm leaving this open for now because we should probably re-evaluate the -moz- prefix usage.

Note: See TracTickets for help on using tickets.