Allow internal link search in wp_link_dialog to actually be hidden using wplink user setting

[coreygilmore]

$show_internal is set in class-wp-editor.php​ using:

$show_internal = '1' == get_user_setting( 'wplink', '0' );

And this is later checked using if( ! $show_internal ), which is never true because $show_internal will either be 1 or empty.

Defaulting to 1 and typecasting as an integer fixes it.

The same basic logic issues exist in wplink.dev.js​, preventing the internal link search box from ever being hidden.

[SergeyBiryukov]

Related: [18498]

The patches don't look like correct SVN patches due to ANSI escape codes, could you please fix them?

[SergeyBiryukov]

FWIW, hiding the internal link search appears to work for me, $show_internal has a proper boolean value.

[coreygilmore]

Patches resubmitted, I unfortunately I was working off r25000, and r25031 changed (and fixed some of the problems) with wplink.js. I'll rework my patches as necessary to fix the remaining issues in the latest rev.

[iseulde]

This changed in [27494] and works for me.