WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 5 months ago

#25123 assigned enhancement

The 'Revisions' post meta box should scroll

Reported by: johnbillion Owned by: adamsilverstein
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Revisions Keywords: needs-patch ux-feedback
Focuses: ui Cc:

Description

When you have a great big long list of revisions on a post the 'Revisions' meta box gets as long as the list of revisions. It should have a max-height and become scrollable.

Attachments (1)

25123.diff (554 bytes) - added by adamsilverstein 17 months ago.

Download all attachments as: .zip

Change History (18)

#1 @helen
3 years ago

Are any other meta boxes scrollable? What does the comments meta box do for many comments?

#2 @helen
3 years ago

  • Keywords ui-focus added

#3 @nacin
3 years ago

We were really close to removing the Revisions meta box in 3.6. A comment from pmaiorana (24804#comment:32) festered, and eventually markjaquith and I reverted it.

I think the best course of action here would be to remove it after we do some revisions improvements.

I'm not necessarily against having this thing scroll, but I question if there is a huge need when it is both collapsible, and also hidden by default.

#4 @johnbillion
3 years ago

I'd give a +1 to removing the meta box now that we have a prominent link in the publish box.

#5 @adamsilverstein
3 years ago

  • Cc adamsilverstein@… added

#7 @adamsilverstein
3 years ago

Although it would be easy to add a scroll bar here the meta box here, I also agree we should just remove the list of revisions on the post page.

A more useful location for the list of revisions would be on the revisions screen itself - perhaps in the form of a sidebar similar to what Google docs does for revisions. This would allow us to leverage the lazy loading of revisions data as well, reducing the initial page memory footprint & load time.

#8 @jkudish
3 years ago

  • Cc jkudish added

#9 @adamsilverstein
17 months ago

  • Keywords has-patch dev-feedback added; needs-patch removed
  • Owner set to adamsilverstein
  • Status changed from new to assigned

In 25123.diff - remove the revisions meta box.

I created a plugin to recreate the meta box @ https://github.com/adamsilverstein/wp-revisions-meta-box

So far, I only removed the actual call adding the meta box; do we want to deprecate the rest of the functionality (and maybe move it to the plugin)? Might wp_list_post_revisions be in use by plugins?

  • Note that this call to wp_get_post_revisions still grabs all revisions for the post, just to get their count and the last revision id. That seems pretty inefficient! (especially for a large number of / large revisions).

#10 @johnbillion
16 months ago

  • Keywords 2nd-opinion added

I think this comment by pmaiorana 24804#comment:32 still holds some weight. There's no way to browse a post's revision history at the moment. If we remove the revisions meta box I think we'll need to replace it with something similar on the revisions screen itself (maybe a tab?).

#11 @johnbillion
16 months ago

Actually a sidebar might work well, as you suggested.

#12 @swissspidy
6 months ago

  • Keywords needs-patch added; has-patch dev-feedback 2nd-opinion removed

A more useful location for the list of revisions would be on the revisions screen itself - perhaps in the form of a sidebar similar to what Google docs does for revisions. This would allow us to leverage the lazy loading of revisions data as well, reducing the initial page memory footprint & load time.

It would be interesting exploring this route.

#13 @swissspidy
6 months ago

  • Keywords ux-feedback added

#14 @karmatosed
6 months ago

I've done two really rough mockups to try and visualise what is being discussed as to show what potentially the sidebar could look like. I've taken literally the existing UI just as a low-fi visualisation. This absolutely should be refined.

v1 makes more sense for the sidebar I feel, but it points to maybe some clarity needed across the whole page.
https://cldup.com/p_1T_LSqTS.png

v2 feels visually more comfortable but makes potentially less sense when you try and read it from a user perspective.
https://cldup.com/iwVCLrfpPS.png

#15 follow-up: @melchoyce
6 months ago

I'd like to do another iteration on this screen in the next couple cycles, but I think for now your second mockup is a good update, @karmatosed. If we brought the revisions metabox onto this screen, we should also highlight in the list whichever revision(s) are being shown.

#16 in reply to: ↑ 15 @adamsilverstein
5 months ago

Thanks for the mockups @karmatosed!

I really like this idea; I think it was something we considered originally for the revisions screen rewrite, but decided against for some reason I can't recall. It would also be great to see some indication of the change size, something like green/red dots or numbers.

I added such of list of revisions in a plugin: https://github.com/adamsilverstein/RevisionsPlus. Happy to work that into a patch if its helpful, I can add the highlighting the selected revision @melchoyce suggested as well.

Would the list get a scrollbar if there are many revisions?

ps. for a trip down memory lane, check out design mockups on #23396

#17 @karmatosed
5 months ago

Could it paginate rather than scroll?

That's a great trip down memory lane @adamsilverstein. I'd be interested in being involved in iterating on things if we ever get time. I still feel revisions is a really important area and the interface can be improved.

Note: See TracTickets for help on using tickets.