WordPress.org

Make WordPress Core

Opened 19 months ago

Last modified 3 weeks ago

#25123 assigned enhancement

The 'Revisions' post meta box should scroll

Reported by: johnbillion Owned by: adamsilverstein
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Revisions Keywords: has-patch dev-feedback 2nd-opinion
Focuses: ui Cc:

Description

When you have a great big long list of revisions on a post the 'Revisions' meta box gets as long as the list of revisions. It should have a max-height and become scrollable.

Attachments (1)

25123.diff (554 bytes) - added by adamsilverstein 2 months ago.

Download all attachments as: .zip

Change History (12)

comment:1 @helen19 months ago

Are any other meta boxes scrollable? What does the comments meta box do for many comments?

comment:2 @helen19 months ago

  • Keywords ui-focus added

comment:3 @nacin18 months ago

We were really close to removing the Revisions meta box in 3.6. A comment from pmaiorana (24804#comment:32) festered, and eventually markjaquith and I reverted it.

I think the best course of action here would be to remove it after we do some revisions improvements.

I'm not necessarily against having this thing scroll, but I question if there is a huge need when it is both collapsible, and also hidden by default.

comment:4 @johnbillion18 months ago

I'd give a +1 to removing the meta box now that we have a prominent link in the publish box.

comment:5 @adamsilverstein18 months ago

  • Cc adamsilverstein@… added

comment:7 @adamsilverstein18 months ago

Although it would be easy to add a scroll bar here the meta box here, I also agree we should just remove the list of revisions on the post page.

A more useful location for the list of revisions would be on the revisions screen itself - perhaps in the form of a sidebar similar to what Google docs does for revisions. This would allow us to leverage the lazy loading of revisions data as well, reducing the initial page memory footprint & load time.

comment:8 @jkudish18 months ago

  • Cc jkudish added

@adamsilverstein2 months ago

comment:9 @adamsilverstein2 months ago

  • Keywords has-patch dev-feedback added; needs-patch removed
  • Owner set to adamsilverstein
  • Status changed from new to assigned

In 25123.diff - remove the revisions meta box.

I created a plugin to recreate the meta box @ https://github.com/adamsilverstein/wp-revisions-meta-box

So far, I only removed the actual call adding the meta box; do we want to deprecate the rest of the functionality (and maybe move it to the plugin)? Might wp_list_post_revisions be in use by plugins?

  • Note that this call to wp_get_post_revisions still grabs all revisions for the post, just to get their count and the last revision id. That seems pretty inefficient! (especially for a large number of / large revisions).

comment:10 @johnbillion3 weeks ago

  • Keywords 2nd-opinion added

I think this comment by pmaiorana 24804#comment:32 still holds some weight. There's no way to browse a post's revision history at the moment. If we remove the revisions meta box I think we'll need to replace it with something similar on the revisions screen itself (maybe a tab?).

comment:11 @johnbillion3 weeks ago

Actually a sidebar might work well, as you suggested.

Note: See TracTickets for help on using tickets.