WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#25129 closed defect (bug) (fixed)

Properly deprecate $network_id argument in get_blog_count()

Reported by: jeremyfelt Owned by: SergeyBiryukov
Milestone: 3.7 Priority: normal
Severity: normal Version: 3.1
Component: Multisite Keywords: has-patch
Focuses: Cc:

Description

Until 3.1, get_blog_count() ran a query on the $wpdb->blogs table based on a site id. This behavior was deprecated when get_site_option() was implemented to return a cached version of the count.

Patch documents this and uses _deprecate_argument()

Attachments (1)

25129.diff (584 bytes) - added by jeremyfelt 7 years ago.

Download all attachments as: .zip

Change History (4)

@jeremyfelt
7 years ago

#1 @SergeyBiryukov
7 years ago

Should it be $site_id rather than $network_id? Looks like we use $site_id when referring to a network ID throughout the core, with populate_network() being the only exception.

#2 @jeremyfelt
7 years ago

I think $network_id as part of an effort to properly name going forward. See IRC conversation from earlier today.

#3 @SergeyBiryukov
7 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 25113:

Deprecate $network_id argument in get_blog_count(). props jeremyfelt. fixes #25129.

Note: See TracTickets for help on using tickets.