Multisite new site domain name: inconsistency with hyphens ms-functions.php vs site-new.php

[lkraav]

trunk/src/wp-includes/ms-functions.php#L557​

if ( preg_match( '/[^a-z0-9]+/', $blogname ) )

vs

trunk/src/wp-admin/network/site-new.php#L43​

if ( preg_match( '|^([a-zA-Z0-9-])+$|', $blog['domain'] ) )

Yes, I'd really like to have hyphens in my subsite domain names. Blaming all the way back to multisite import doesn't reveal any particular reasoning why hyphens are historically disallowed. Since hyphens are a normal part of the DNS system, I see no reason why they should be banned.

I would suggest matching also for "-" in ms-functions.php.

[SergeyBiryukov]

Duplicate of #20019.

[lkraav]

Meh, tried hard finding "hyphen" with search.

Re ticket subjects, how was I supposed to search for that? Any search like "-" is basically nonsense.

[SergeyBiryukov]

I've remembered that we have a similar ticket slated for 3.7, so I searched for "Multisite inconsistency" and found #17397. It was not an exact duplicate, however there was a link to #20019 in the comments.

It could also be found by "wpmu_validate_blog_signup".

[lkraav]

True, searching for function name makes sense.