comment_form() function treats $args as array before passing $args through wp_parse_args()

[tomdxw]

To reproduce simply call comment_form('fields=author'); with WP_DEBUG switched on. It will result in the following errors:

PHP Warning: Illegal string offset 'format' in /path/to/wordpress/wp-includes/comment-template.php on line 1610
PHP Warning: Illegal string offset 'format' in /path/to/wordpress/wp-includes/comment-template.php on line 1614

This appears to be a bug introduced in 3.6.

[SergeyBiryukov]

Introduced in [24417].

[SergeyBiryukov]

The simplest solution is probably to call wp_parse_args() twice.

[nacin]

If current_theme_supports( 'html5', 'comment-form' ) ? 'html5' : 'xhtml' is added to the $defaults array for 'format', would that work? Then these lines could be removed.

[SergeyBiryukov]

Replying to nacin:

If current_theme_supports( 'html5', 'comment-form' ) ? 'html5' : 'xhtml' is added to the $defaults array for 'format', would that work? Then these lines could be removed.

No, we use it to set $fields, which is a part of $defaults array itself: tags/3.6/wp-includes/comment-template.php#L1614​.

[nacin]

I think 25151.patch​ is probably good, then.

[SergeyBiryukov]

In 25151:

Make sure $args is an array before treating it as such. fixes #25151 for trunk.

[SergeyBiryukov]

In 25152:

Make sure $args is an array before treating it as such. fixes #25151 for 3.6.