Changes between Initial Version and Version 1 of Ticket #25161, comment 4
- Timestamp:
- 08/28/2013 10:43:31 PM (12 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #25161, comment 4
initial v1 3 3 Yeah, not particularly happy with it too. Filtering PHP code with a regex is not ideal. If we end up doing something like this, at least the filter should be really simple. 4 4 5 Setting something in /src that is removed by Grunt in /build can work. One problem is that the `processContentExclude` option on the copy task works only on directories, and we don't want to process hundreds or thousands of files. We can work around this by setting two 'copy' tasks, the first will copy all files except the file(s) need processing and the second will copy and process the remaining file(s).5 Setting something in /src that is removed by Grunt in /build can work. One problem is that the `processContentExclude` option on the copy task works only on directories, and we don't want to process hundreds or thousands of files. We can work around this by setting two 'copy' tasks, the first will copy all files except the file(s) that need processing and the second will copy and process the remaining file(s). 6 6 7 7 Thinking the proper place to do this is in version.php. How about we add `-src` to the end of `$wp_version`? This will make the filtering regex much simpler. 8 8 9 Another thin k that can be handled there is cache-bustingjs and css in /build. Bumpbot was pretty good about it, now we need an alternative.9 Another thing that can be handled there is cache-busting for js and css in /build. Bumpbot was pretty good about it, now we need an alternative.