Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#25182 closed defect (bug) (fixed)

Avoid validating wildcard hostnames in populate_network() when multisite is already activated

Reported by: jeremyfelt's profile jeremyfelt Owned by: nacin's profile nacin
Milestone: 3.7 Priority: normal
Severity: normal Version:
Component: Multisite Keywords: has-patch
Focuses: Cc:

Description

populate_network() does a few things that are specific to an installation going through the conversion from single site to multisite. The last step is to check if it is a subdomain install, then generate a random string to test whether wildcard DNS is configured correctly.

Most likely, if populate_network() is being used after the initial conversion, we are already aware of our DNS capabilities. Aside from the unnecessary HTTP request that is made by the server at this point, if wildcard DNS is not in place, a related WP_Error is returned even though the entire operation was successful.

Attached patch folds the wildcard DNS check into the if ( ! multisite() ) {} block so that it is only checked during initial conversion.

Attachments (2)

25182.diff (3.8 KB) - added by jeremyfelt 11 years ago.
25182.2.diff (564 bytes) - added by nacin 11 years ago.

Download all attachments as: .zip

Change History (6)

@jeremyfelt
11 years ago

@nacin
11 years ago

#1 @nacin
11 years ago

25182.2.diff does this with less churn. Thoughts?

#2 @jeremyfelt
11 years ago

And so it does. :) I like it.

#3 @nacin
11 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 25171:

Avoid validating wildcard hostnames in populate_network() when multisite is already activated.

props jeremyfelt.
fixes #25182.

#4 @jeremyfelt
11 years ago

  • Milestone changed from Awaiting Review to 3.7
Note: See TracTickets for help on using tickets.