Make WordPress Core

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#25185 closed task (blessed) (fixed)

Move wp-config-sample.php and wp-config.php to the root of the develop repo

Reported by: nacin Owned by: nacin
Milestone: 3.7 Priority: normal
Severity: normal Version:
Component: General Keywords: needs-handbook
Focuses: Cc:

Description

Parent ticket is #24976 for develop.svn.wordpress.org.

This was discussed in IRC a bit yesterday.

wp-config-sample.php should sit in the root of develop.svn, and be copied to the /build directory during grunt's copy task. When setup-config.php creates a wp-config.php file, it should create it in the root of develop.svn, not inside /src.

[25165] already changed it so wp-tests-config-sample.php (and wp-tests-config.php) sit in the same root.

Change History (6)

#1 @nacin
8 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 25173:

Move wp-config-sample.php to the root of develop.svn.

wp-config.php is now created in the root. wp-config-sample.php is properly copied over to the build directory for syncing to core.svn.

Add some ignores.

fixes #25185, see #24976.

#2 follow-up: @DrewAPicture
8 years ago

  • Keywords needs-handbook added

@kimparsell noted that we'll need to update the CCH (core contributor handbook) to reflect that anyone (new to) contributing to core should now be checking out the entire develop.svn package, then pointing their local server to <directory>/src/ — otherwise, they won't get a copy of wp-config-sample.php to install locally.

#3 in reply to: ↑ 2 @nacin
8 years ago

Replying to DrewAPicture:

@kimparsell noted that we'll need to update the CCH (core contributor handbook) to reflect that anyone (new to) contributing to core should now be checking out the entire develop.svn package, then pointing their local server to <directory>/src/ — otherwise, they won't get a copy of wp-config-sample.php to install locally.

Basically what this means is if you want to use develop.svn, you need to check out everything. This makes sense as src is dependent on grunt for full functionality/power.

But if you only want to check out the source, you can still check out http://core.svn.wordpress.org/trunk, which does give you wp-config-sample.php.

You can technically also run WordPress out of build but I don't think all the tools are quite there yet.

#4 follow-up: @kpdesign
8 years ago

We want the handbook to reflect the best practices a new contributor should follow; therefore, we should recommend they check out the entire package, and install from there.

I know that patches will currently work from the core.svn, as well as /src, but the "best practice" should be to create a patch from the root of develop.svn, correct?

#5 in reply to: ↑ 4 ; follow-up: @nacin
8 years ago

Replying to kpdesign:

I know that patches will currently work from the core.svn, as well as /src, but the "best practice" should be to create a patch from the root of develop.svn, correct?

Correct. I was only replying to "otherwise, they won't get a copy of wp-config-sample.php to install locally" — Unless they were checking out only /trunk/src, which is weird, they would always have a copy of the sample config file.

#6 in reply to: ↑ 5 @DrewAPicture
8 years ago

Replying to nacin:

I was only replying to "otherwise, they won't get a copy of wp-config-sample.php to install locally" — Unless they were checking out only /trunk/src, which is weird, they would always have a copy of the sample config file.

I meant in the context of previously checking out directly from core.svn into a local directory. And since we're recommending checkout out the develop.svn root, that doesn't apply anymore :)

Note: See TracTickets for help on using tickets.