IS_PROFILE_PAGE not detectable by plugins on Network/user-edit page

[Ipstenu]

I was testing MP6, which uses if ( defined( 'IS_PROFILE_PAGE' ) ) to detect if you're on a profile page, and to load a JS there if so.

When I went to /wp-admin/network/user-edit.php their JS wasn't loading.

If I add define('IS_PROFILE_PAGE', true); to that page, everything works, but it appears that the require for /wp-admin/user-edit.php doesn't pull that define in.

No idea at all if this is the right fix to force it in, or if the plugin should be detecting something else, or if this is endemic of an even bigger problem.

[Ipstenu]

Adding in the define by force

[SergeyBiryukov]

IS_PROFILE_PAGE is only defined when you're viewing your own profile, in which case you're on wp-admin/network/profile.php, not on wp-admin/network/user-edit.php. The latter URL is only used for editing another users.

[Ipstenu]

Replying to SergeyBiryukov:

IS_PROFILE_PAGE is only defined when you're viewing your own profile

No it's not. It's also called when I, the admin, am editing someone else's profile. At least it is on a single site instance, or when I go to edit a user on a specific site of a Multisite network. It's not when I'm using the network edit user link.

[dd32]

You're both "right".

IS_PROFILE_PAGE is defined in single-site for both user-edit AND profile.php. It's defined as true when it's your own profile, false when it's not. It's not defined in the Network Admin at all. ever.

It's, IMHO, a vestige of the past and only there for compatibility purposes. MP6 and other plugins shouldn't be using it. Instead, plugins should be checking what the current screen is instead.

IMHO, This is a invalid/wontfix ticket.

[SergeyBiryukov]

Replying to dd32:

IS_PROFILE_PAGE is defined in single-site for both user-edit AND profile.php. It's defined as true when it's your own profile, false when it's not.

Yes, by "defined" I meant "true", sorry for being unclear. There's a check in user-edit.php:
​http://core.trac.wordpress.org/browser/tags/3.6/wp-admin/user-edit.php#L14

Replying to dd32:

It's not defined in the Network Admin at all. ever.

It is for me, on the same conditions as in single site. Network admin just includes profile.php and user-edit.php from the main wp-admin directory:
​http://core.trac.wordpress.org/browser/tags/3.6/wp-admin/network/profile.php
​http://core.trac.wordpress.org/browser/tags/3.6/wp-admin/network/user-edit.php

[dd32]

It is for me

oops, right, I forgot it's just using the single-site files, and didn't actually test it.

[SergeyBiryukov]

So, IS_PROFILE_PAGE is only true when viewing your own profile, and false otherwise, in both single site and Multisite. This appears to be the expected behaviour, I don't see a bug here.

[helen]

That's my experience - IS_PROFILE_PAGE indicates you are editing your own profile. MP6 is doing this wrong.

[Ipstenu]

The WP is 'doing it wrong' too, because IS_PROFILE_PAGE also works when an admin is editing another user's profile. So if that's not expected behavior, shouldn't WP be fixed?

[SergeyBiryukov]

Replying to Ipstenu:

The WP is 'doing it wrong' too, because IS_PROFILE_PAGE also works when an admin is editing another user's profile.

It does not for me on a clean install. There's a check in user-edit.php that explicitly defines IS_PROFILE_PAGE as true only if it's your own profile: ​http://core.trac.wordpress.org/browser/tags/3.6/wp-admin/user-edit.php#L14.

Is it defined somewhere earlier on your install?

[Ipstenu]

Not that I'm aware of, but it's time to strip mine my install and hunt it down :) Let's assume my install is screwy and MP6 should do it different.

[nacin]

IS_PROFILE_PAGE is always defined on user-edit.php or profile.php. On profile.php, it is defined as true. On user-edit.php, if it is not defined, it is defined as false (or true, if you managed to hit your profile directly via user-edit.php).

I am not sure why MP6 wasn't working here. But I wouldn't recommend ever consulting IS_PROFILE_PAGE directly.

[helen]

I fixed MP6: ​http://plugins.trac.wordpress.org/changeset/765851