WordPress.org

Make WordPress Core

Opened 8 months ago

Closed 7 months ago

#25209 closed enhancement (fixed)

Twenty Fourteen: Add Styling for Media Element Players

Reported by: celloexpressions Owned by: lancewillett
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

We should style the audio and video players to match the design of Twenty Fourteen. I made a quick patch modeled after Twenty Thirteen's handling, but featuring a pure black background (like the header/sidebar/footer) and the green link/accent color for the current-time rail (see screenshot).

Attachments (4)

twentyfourteen-mediaelements.diff (1.1 KB) - added by celloexpressions 8 months ago.
Introduce styling for the native audio and video players, modeled after Twenty Thirteen's handling
twentyfourteen-mediaelements-audio.png (9.2 KB) - added by celloexpressions 8 months ago.
Before/After of the audio player with the patch applied.
25209.2.diff (1.3 KB) - added by celloexpressions 8 months ago.
Remove another gradient, add vertical spacing between players (currently with an arbitrary/placeholder value)
25209.3.diff (977 bytes) - added by iamtakashi 7 months ago.

Download all attachments as: .zip

Change History (11)

celloexpressions8 months ago

Introduce styling for the native audio and video players, modeled after Twenty Thirteen's handling

celloexpressions8 months ago

Before/After of the audio player with the patch applied.

comment:1 lancewillett8 months ago

  • Milestone changed from Awaiting Review to 3.8

comment:2 follow-up: obenland8 months ago

Is .hentry necessary in the selectors?

comment:3 in reply to: ↑ 2 celloexpressions8 months ago

Replying to obenland:

Is .hentry necessary in the selectors?

We need to use a wrapper of some sort so that the selectors are more specific than the ones that WordPress uses for its default styling (which are loaded after our stylesheet). It was .hentry in Twenty Thirteen.

celloexpressions8 months ago

Remove another gradient, add vertical spacing between players (currently with an arbitrary/placeholder value)

comment:4 iamtakashi8 months ago

  • Cc takashi@… added

comment:5 lancewillett8 months ago

In 25260:

Twenty Fourteen: add styling for medialement players, props celloexpressions. See #25209.

iamtakashi7 months ago

comment:6 iamtakashi7 months ago

The mediaelement style looks great. Thanks celloexpressions. I adjusted slightly the spacing with the patch above.

comment:7 lancewillett7 months ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 25267:

Twenty Fourteen: further styling for medialement players, props iamtakashi. Fixes #25209.

Note: See TracTickets for help on using tickets.