In get_pages, don't require hierarchical => false for parent arg

[wonderboymusic]

parent requires hierarchical => false, which defaults to true. Should set to false automatically.

[wonderboymusic]

In 25245:

Set hierarchical to false when parent is passed to get_pages() and child_of is not.

Fixes #25230.

[SergeyBiryukov]

Can this be simplified along the lines of the first change in [23599]? See 25230.diff​.

[wonderboymusic]

In 25270:

Simplify the check for false-y child_of arg.

Props SergeyBiryukov.
See #25230, [25245].

[chrisbliss18]

Fix for bug that disables hierarchical when parent is -1 (which it is by default)

[chrisbliss18]

Added a new patch for this issue as the original one introduced a bug that causes the hierarchical argument, which is enabled by default, to be disabled when -1 is supplied for the parent argument, it is -1 by default.

The problem seems to be that in simplifying the conditional, the "> 0" portion of the conditional was removed. Since -1 is truthy, the conditional incorrectly applied when -1 was supplied for parent.

My supplied patch, 25230.1.diff, fixes this issue.

[SergeyBiryukov]

25230.1.diff​ looks good, please open a new ticket and upload the patch there. This one was closed on a completed milestone.

[chrisbliss18]

Will do. I wasn't sure about the process on such issues.