WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #25237, comment 2


Ignore:
Timestamp:
09/09/2013 02:17:17 AM (7 years ago)
Author:
dd32
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #25237, comment 2

    initial v1  
    55All - The return results of fwrite()'s were not being checked, as a result, it was possible for it to read/write half a file and return that as a successful read/write. This results in partially written files.
    66
    7 FTP Sockets - Forcing all writes and reads to `FTP_BINARY`, the FTP class in use will auto-convert line endings to \n or \r\n on linux/windows servers, this will cause file verification failures in future.
     7FTP Sockets - Forcing all writes and reads to `FTP_BINARY`, when using `FTP_ASCII` the FTP class in use will auto-convert line endings to \n or \r\n on linux/windows servers, this will cause file verification failures in future.
    88
    99FTP / SSH - These supported 2 extra args which the Direct class don't, `$type` (ASCII or BINARY), and `$resumepos` (which wasn't always respected). Neither were respected by SSH2.  These are removed in the patch since Direct doesn't support them, and they haven't been able to be relied upon.   Any plugin using the `$resumepos` parameter would have only worked with the FTP Extension, and the `$type` variable removal will not negatively affect any plugin at all.